Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for contact migration into the contact module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_contact_category
  • d6_contact_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#6 interdiff-2534006-2-6.txt3.98 KBphenaproxima
#6 2534006-6.patch7.38 KBphenaproxima
#2 2534006-2.patch5.86 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2534006-2.patch5.86 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2534006-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2534006-6.patch7.38 KB
interdiff-2534006-2-6.txt3.98 KB

Moved the tests into the Drupal\contact\Tests\Migrate namespace, and the schema for the d6_contact_settings source plugin into contact.schema.yml.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review

Unblocked.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Status: Needs review » Reviewed & tested by the community

Suppose it good to go, just moval of files

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 0fc922d and pushed to 8.0.x. Thanks!

  • alexpott committed 0fc922d on 8.0.x 
    Issue #2534006 by phenaproxima: Move module-specific migration support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.