Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for comment migration into the comment module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_comment
  • d6_comment_entity_display
  • d6_comment_entity_form_display
  • d6_comment_entity_form_display_subject
  • d6_comment_field
  • d6_comment_field_instance
  • d6_comment_type

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#15 2534004-15.patch24.26 KBphenaproxima
#13 interdiff-2534004-11-13.txt566 bytesphenaproxima
#13 2534004-13.patch24.24 KBphenaproxima
#11 2534004-11.patch24.24 KBphenaproxima
#9 2534004-9.patch22.73 KBphenaproxima
#5 interdiff-2534004-2-5.txt13.82 KBphenaproxima
#5 2534004-5.patch20.36 KBphenaproxima
#2 2534004-2.patch17.17 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2534004-2.patch17.17 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2534004-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2534004-5.patch20.36 KB
new interdiff-2534004-2-5.txt13.82 KB

Moved the tests into the Drupal\comment\Tests\Migrate namespace, and schema for comment-related source plugins into comment.schema.yml.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Needs review

Unblocked.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

Was a little confused at CommentTest.php not showing up as a move, but I presume that because it's so short, the namespace changes made too high a percentage of lines change... Looks good to me.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Reviewed & tested by the community » Needs work

After applying all the move patches, I believe the following still need to be moved to the comment module:

  • EntityComment.php
  • EntityCommentType.php
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534004-9.patch22.73 KB

Moved. interdiff didn't feel like cooperating, for some reason, so I'm sorry about the lack of that.

Status: Needs review » Needs work

The last submitted patch, 9: 2534004-9.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534004-11.patch24.24 KB

I was having trouble re-rolling...things seem to be hashed up in #9. So I re-did the entire thing. Fingers crossed that testbot likes it!

Status: Needs review » Needs work

The last submitted patch, 11: 2534004-11.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534004-13.patch24.24 KB
new interdiff-2534004-11-13.txt566 bytes

What a difference a single character makes.

Status: Needs review » Needs work

The last submitted patch, 13: 2534004-13.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534004-15.patch24.26 KB

Re-rolled.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Moar moving code around. Committed and pushed to 8.0.x. Thanks!

  • webchick committed 05a8db2 on 8.0.x 
    Issue #2534004 by phenaproxima, mikeryan: Move module-specific migration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.