Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for book migration into the book module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_book
  • d6_book_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#9 interdiff-2534002-6-9.txt568 bytesphenaproxima
#9 2534002-9.patch4.15 KBphenaproxima
#6 interdiff-2534002-2-6.txt3.12 KBphenaproxima
#6 2534002-6.patch4.15 KBphenaproxima
#2 2534002-2.patch3.23 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Status: Active » Needs review
FileSize
2534002-2.patch3.23 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2534002-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Status: Needs work » Postponed
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
FileSize
2534002-6.patch4.15 KB
interdiff-2534002-2-6.txt3.12 KB

Moved the tests into the Drupal\book\Tests\Migrate namespace, and moved the book destination plugin into Book.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Status: Postponed » Needs review

Unblocked.

Status: Needs review » Needs work

The last submitted patch, 6: 2534002-6.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2534002-9.patch4.15 KB
interdiff-2534002-6-9.txt568 bytes

Fixed a typo in a namespace.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed e47b6a7 and pushed to 8.0.x. Thanks!

  • alexpott committed e47b6a7 on 8.0.x 
    Issue #2534002 by phenaproxima: Move module-specific migration support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.