Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for block_content migration into the block_content module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_block_content_body_field
  • d6_block_content_type
  • d6_custom_block

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#8 2533994-8.patch5.81 KBphenaproxima
#4 interdiff-2533994-1-4.txt2.53 KBphenaproxima
#4 2533994-4.patch5.77 KBphenaproxima
#1 2533994-1.patch4.28 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Assigned: Unassigned » phenaproxima
Status: Active » Needs review
FileSize
2533994-1.patch4.28 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2533994-1.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2533994-4.patch5.77 KB
interdiff-2533994-1-4.txt2.53 KB

Moved the tests into the Drupal\block_content\Tests\Migrate namespace, and moved the d6_box source plugin schema into block_content.schema.yml.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2533994-8.patch5.81 KB

Re-rolled. Can't generate an interdiff due to the conflicts which, well, necessitated the reroll. :)

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Reviewed & tested by the community

Presumptive RTBC assuming testbot passes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 6220d90 and pushed to 8.0.x. Thanks!

  • alexpott committed 6220d90 on 8.0.x 
    Issue #2533994 by phenaproxima: Move module-specific migration support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.