Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for aggregator migration into the aggregator module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_aggregator_feed
  • d6_aggregator_item
  • d6_aggregator_settings
  • d7_aggregator_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#5 interdiff-2533984-2-5.txt5.67 KBphenaproxima
#5 2533984-5.patch10.2 KBphenaproxima
#2 2533984-2.patch10.04 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2533984-2.patch10.04 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2533984-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2533984-5.patch10.2 KB
new interdiff-2533984-2-5.txt5.67 KB

Moved the tests into the Drupal\aggregator\Tests\Migrate namespace.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Needs review

Unblocked.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4104c3f and pushed to 8.0.x. Thanks!

  • alexpott committed 4104c3f on 8.0.x 
    Issue #2533984 by phenaproxima: Move module-specific migration support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.