Reference dialog is not working for Taxonomy term added with parent term [#2533678]

Comment	File	Size	Author
#8	references_dialog-2533678-8.patch	4.87 KB	eyilmaz

#3	references_dialog-not-working-for-term-added-with-parent-term-2533678-3.patch	1.26 KB	laxman.ghavte

Comment #1

laxman.ghavte CreditAttribution: laxman.ghavte commented 15 July 2015 at 12:21

Issue summary:

View changes

Log in or register to post comments

Comment #2

laxman.ghavte CreditAttribution: laxman.ghavte commented 15 July 2015 at 12:22

Title:

Reference dialog is not working for Entity reference Taxonomy term if term relationship

» Reference dialog is not working for Taxonomy term added with parent term

Log in or register to post comments

Comment #3

laxman.ghavte CreditAttribution: laxman.ghavte at Faichi Solutions Pvt Ltd commented 16 July 2015 at 05:29

File	Size
references_dialog-not-working-for-term-added-with-parent-term-2533678-3.patch	1.26 KB

After saving new term with Parent term relationship, first hook_entity_insert() get triggered and then hook_entity_update(). After hook_entity_update() it looses its id and pass wrong id in $_GET['destination'].

I have fixed this issue. Please check the attached patch.

Log in or register to post comments

Comment #4

laxman.ghavte CreditAttribution: laxman.ghavte at Faichi Solutions Pvt Ltd commented 16 July 2015 at 05:47

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #5

laxman.ghavte CreditAttribution: laxman.ghavte at Faichi Solutions Pvt Ltd commented 15 October 2015 at 07:13

Assigned:

laxman.ghavte

» Unassigned

Log in or register to post comments

Comment #6

makbul_khan8 CreditAttribution: makbul_khan8 at Faichi Solutions Pvt Ltd commented 15 October 2015 at 07:15

Assigned:	Unassigned	» makbul_khan8
Status:	Needs review	» Reviewed & tested by the community

Code works fine.

Log in or register to post comments

Comment #7

eyilmaz

German

Berlin, Germany

CreditAttribution: eyilmaz commented 10 November 2015 at 11:50

Status:

Reviewed & tested by the community

» Needs work

There is a problem with this patch if you create an entity via references_dialog in which you also add another entity.
With this patch, we assume, that the first created/updated entity is the entity for this dialog, which is the case for taxonomy terms with parent selection (because vocabulary is updated, if hierarchy is changed), but not for new entities with new file upload for example.
We need a function to detect or determine if the updated or created entity is the right one in hook_entity_update and hook_entity_insert..