Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Jul 2015 at 01:30 UTC
Updated:
29 Jul 2015 at 11:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hussainwebThis should be green. I have removed hiddeninput.exe from the changes due to #2531796: Fix hiddeninput.exe in symfony/console.
Comment #2
hussainwebFixing link to changelog.
Comment #3
fabianx commentedComment #4
dawehnerWell, I think the split would have not been needed.
Comment #5
hussainweb@dawehner: Yes, it is not a large patch compared to our usual standards, but it is there if it helps making the other patch easier to review. If that goes through anyway, this can be closed as duplicate.
Comment #6
hussainweb@dawehner: Also, see my concerns on the other patch in #2526412-29: Remove Singleton hack in registerWithSymfonyGuesser. It was after that I thought a smaller patch would make it helpful to review and isolate changes.
Comment #7
catchThe split isn't strictly necessary, but I like two commits at least for git history. Committed/pushed to 8.0.x, thanks!