Follow-up to #2504967: Upgrade to Symfony 2.7.1

Symfony 2.7.2 is now released.

Have a skim of the issue summary on #2454393: Upgrade to Symfony 2.6.5 for a better overview of why upgrading point releases is a good idea :).

This has security fixes, changelog below, and hence marking as major. This is also related to #2526412: Remove Singleton hack in registerWithSymfonyGuesser which is a major task.

Changelog changelog.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is an external library upgrade.
Issue priority Major because this release contains security fixes.
Disruption Not disruptive.
CommentFileSizeAuthor
#1 upgrade_to_symfony_2_7_2-2533360-1.patch230.63 KBhussainweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Status: Active » Needs review
FileSize
upgrade_to_symfony_2_7_2-2533360-1.patch230.63 KB

This should be green. I have removed hiddeninput.exe from the changes due to #2531796: Fix hiddeninput.exe in symfony/console.

hw@d8:/var/www/d8task/core-[git 8.0.x] $ composer update symfony/*
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing symfony/class-loader (v2.7.1)
  - Installing symfony/class-loader (v2.7.2)
    Downloading: 100%

  - Removing symfony/console (v2.7.1)
  - Installing symfony/console (v2.7.2)
    Downloading: 100%

  - Removing symfony/css-selector (v2.7.1)
  - Installing symfony/css-selector (v2.7.2)
    Loading from cache

  - Removing symfony/dependency-injection (v2.7.1)
  - Installing symfony/dependency-injection (v2.7.2)
    Downloading: 100%

  - Removing symfony/debug (v2.7.1)
  - Installing symfony/debug (v2.7.2)
    Downloading: 100%

  - Removing symfony/http-foundation (v2.7.1)
  - Installing symfony/http-foundation (v2.7.2)
    Downloading: 100%

  - Removing symfony/event-dispatcher (v2.7.1)
  - Installing symfony/event-dispatcher (v2.7.2)
    Downloading: 100%

  - Removing symfony/http-kernel (v2.7.1)
  - Installing symfony/http-kernel (v2.7.2)
    Downloading: 100%

  - Removing symfony/routing (v2.7.1)
  - Installing symfony/routing (v2.7.2)
    Downloading: 100%

  - Removing symfony/serializer (v2.7.1)
  - Installing symfony/serializer (v2.7.2)
    Downloading: 100%

  - Removing symfony/translation (v2.7.1)
  - Installing symfony/translation (v2.7.2)
    Downloading: 100%

  - Removing symfony/validator (v2.7.1)
  - Installing symfony/validator (v2.7.2)
    Downloading: 100%

  - Removing symfony/process (v2.7.1)
  - Installing symfony/process (v2.7.2)
    Downloading: 100%

  - Removing symfony/yaml (v2.7.1)
  - Installing symfony/yaml (v2.7.2)
    Downloading: 100%

  - Removing symfony/dom-crawler (v2.7.1)
  - Installing symfony/dom-crawler (v2.7.2)
    Downloading: 100%

  - Removing symfony/browser-kit (v2.7.1)
  - Installing symfony/browser-kit (v2.7.2)
    Downloading: 100%

Writing lock file
Generating autoload files
hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Issue summary: View changes

Fixing link to changelog.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented

Well, I think the split would have not been needed.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented

@dawehner: Yes, it is not a large patch compared to our usual standards, but it is there if it helps making the other patch easier to review. If that goes through anyway, this can be closed as duplicate.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented

@dawehner: Also, see my concerns on the other patch in #2526412-29: Remove Singleton hack in registerWithSymfonyGuesser. It was after that I thought a smaller patch would make it helpful to review and isolate changes.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

The split isn't strictly necessary, but I like two commits at least for git history. Committed/pushed to 8.0.x, thanks!

  • catch committed eafa3a2 on 8.0.x 
    Issue #2533360 by hussainweb: Upgrade to Symfony 2.7.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.