Many spelling mistakes in module

CommentFileSizeAuthor
#6 interdiff-2533030-5-6.txt446 bytesmegachriz
#6 feeds-spelling-errors-2533030-6.patch3.76 KBmegachriz
#5 spelling-error-2533030-5.patch3.33 KBrrfegade
#1 spelling-mistakes-2533030-1.patch8.92 KBrrfegade

Comments

rrfegade’s picture

rrfegade commented
Status: Active » Needs review
StatusFileSize
new spelling-mistakes-2533030-1.patch8.92 KB
twistor’s picture

twistor commented
Status: Needs review » Needs work

We shouldn't include the fixes in the test files. Those are samples of real RSS feeds. Many modules are using that for tests, so fixing it could break things needlessly.

rrfegade’s picture

rrfegade commented

But there is no change in the code its just the spelling mistakes corrections, so this can be merge right? if not then should i remove the changes done in RSS feeds files and create the patch again?

twistor’s picture

twistor commented

if not then should i remove the changes done in RSS feeds files and create the patch again?

Yes, that. Those files are used during testing, so we can't just change them for no reason. Other modules are also using them for tests.

rrfegade’s picture

rrfegade commented
Status: Needs work » Needs review
StatusFileSize
new spelling-error-2533030-5.patch3.33 KB

pfa the revised patch

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-spelling-errors-2533030-6.patch3.76 KB
new interdiff-2533030-5-6.txt446 bytes

Seems O.K. to me. I added back the correction for the FeedsMapperProfileTestCase from #1. Only source files (in feeds/tests/feeds) shouldn't be corrected. Corrections in code comments in tests are okay to do.

  • MegaChriz committed 3a2b4de on 7.x-2.x authored by rrfegade 
    Issue #2533030 by rrfegade, MegaChriz, twistor: Spelling errors in D7
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #6, though credited to rrfegade.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.