Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Many spelling mistakes in module
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-2533030-5-6.txt | 446 bytes | MegaChriz |
| #6 | feeds-spelling-errors-2533030-6.patch | 3.76 KB | MegaChriz |
| #5 | spelling-error-2533030-5.patch | 3.33 KB | rrfegade |
| #1 | spelling-mistakes-2533030-1.patch | 8.92 KB | rrfegade |
Comments
Comment #1
rrfegade CreditAttribution: rrfegade as a volunteer commentedComment #2
twistor CreditAttribution: twistor as a volunteer commentedWe shouldn't include the fixes in the test files. Those are samples of real RSS feeds. Many modules are using that for tests, so fixing it could break things needlessly.
Comment #3
rrfegade CreditAttribution: rrfegade as a volunteer commentedBut there is no change in the code its just the spelling mistakes corrections, so this can be merge right? if not then should i remove the changes done in RSS feeds files and create the patch again?
Comment #4
twistor CreditAttribution: twistor as a volunteer commentedYes, that. Those files are used during testing, so we can't just change them for no reason. Other modules are also using them for tests.
Comment #5
rrfegade CreditAttribution: rrfegade as a volunteer commentedpfa the revised patch
Comment #6
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedSeems O.K. to me. I added back the correction for the FeedsMapperProfileTestCase from #1. Only source files (in feeds/tests/feeds) shouldn't be corrected. Corrections in code comments in tests are okay to do.
Comment #8
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedCommitted #6, though credited to rrfegade.