views.inc

line #1483

// Noone should have access to disabled views.

should be

// No one should have access to disabled views.

CommentFileSizeAuthor
#11 typo_in_views-2532932-11.patch475 bytesselvanathan
#7 views-typo_error-2532932-7.patch475 bytessnehi
#5 views-typo_error-2532932-5.patch475 bytessnehi
#1 typo-2532932.patch475 bytespushpinderchauhan

Comments

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Active » Needs review
StatusFileSize
new typo-2532932.patch475 bytes

Fixed the TYPO.

Status: Needs review » Needs work

The last submitted patch, 1: typo-2532932.patch, failed testing.

Status: Needs work » Needs review

er.pushpinderrana queued 1: typo-2532932.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: typo-2532932.patch, failed testing.

snehi’s picture

snehi commented
Status: Needs work » Needs review
StatusFileSize
new views-typo_error-2532932-5.patch475 bytes

Please review attached patch.

Status: Needs review » Needs work

The last submitted patch, 5: views-typo_error-2532932-5.patch, failed testing.

snehi’s picture

snehi commented
StatusFileSize
new views-typo_error-2532932-7.patch475 bytes
joshuautley’s picture

joshuautley commented

One of these days I will take the time to learn how to create Patches. Thank you for stepping up. (=

snehi’s picture

snehi commented

We are unable to find the 7.x-3.11 instead we are patching 7.x-3.x.

selvanathan’s picture

selvanathan commented
Assigned: Unassigned » selvanathan
selvanathan’s picture

selvanathan commented
StatusFileSize
new typo_in_views-2532932-11.patch475 bytes
selvanathan’s picture

selvanathan commented
Status: Needs work » Needs review

Review my patch

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: selvanathan » Unassigned

#11 is identical to #7 and was unnecessary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-3.11 » 7.x-3.x-dev
Status: Needs review » Fixed
Parent issue: » #2855120: Plan for Views 7.x-3.16 release

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.