Closed (fixed)
Project:
Webform
Version:
7.x-4.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Jul 2015 at 12:58 UTC
Updated:
29 Jul 2015 at 20:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
danchadwick commentedConfirmed, but it's not clear what we want. I think the intention of prefixing the submission info fields with webform_ is to prevent conflicts with actual component form keys. But the command doesn't accept form keys, but rather component cid's.
I see three options for this isssue:
I like Option 3 myself. Comments?
Comment #2
morenstratI'm also in favor of option 3 and created a patch for it.
Comment #3
danchadwick commentedVery nice. My comments are trivial and stylistic only. I haven't tested it yet, but it looks good.
Unneeded blank lines.
Combine these lines, I think.
Need an unset of $component. Reference loop variables are PHP timebombs.
Comment #4
morenstratNew patch attached!
Comment #5
danchadwick commentedThanks very much!
To clarify my third comment, I don't object to reference loop variables, but they need to be unset immediately after to loop. If you happen to (maybe years later) reuse that variable name, it will still be a reference, leading to much hair pulling. I restored your original version of the loop and added an unset.
Committed to 7.x-4.x and 8.x.
Also, one tiny request: if you name patches according to the Drupal convention, it is easier for maintainers to track them.