In #2510104: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future we removed var drupalSettings - we missed an assertion about its absence in NoJavaScriptAnonymousTest

Test only change permitted in beta.

CommentFileSizeAuthor
drupal8.drupalSettings.patch813 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented

RTBC + 1

  • xjm committed 6f78b08 on 8.0.x 
    Issue #2532604 by alexpott: Fix reference to "var drupalSettings" in...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Definitely a much better test.This issue only changes test code, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Definitely a much better test.

It wasn't possible to do it differently before #2510104: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future :)

But, yes, totally agreed that this is much better!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.