In #2510104: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future we removed var drupalSettings - we missed an assertion about its absence in NoJavaScriptAnonymousTest

Test only change permitted in beta.

CommentFileSizeAuthor
drupal8.drupalSettings.patch813 bytesalexpott

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
fabianx’s picture

fabianx commented

RTBC + 1

  • xjm committed 6f78b08 on 8.0.x 
    Issue #2532604 by alexpott: Fix reference to "var drupalSettings" in...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Definitely a much better test.This issue only changes test code, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Definitely a much better test.

It wasn't possible to do it differently before #2510104: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future :)

But, yes, totally agreed that this is much better!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.