So Google decided to add other meta tags for use with their Custom Search Engine (CSE) service:

  • Thumbnail: <meta name="thumbnail" content="http://example/foo.jpg" />
  • Department: <meta name="department" content="legal" />
  • Content audience: <meta name="audience" content="all" />
  • Document status: <meta name="doc_status" content="draft" />
  • Results sorting: <meta name="rating" content="5" />

https://support.google.com/customsearch/answer/1626955?hl=en
https://support.google.com/customsearch/answer/2595557?hl=en

These would go best in a submodule called "metatag_google_cse".

CommentFileSizeAuthor
#31 metatag-n2532588-31.interdiff.txt575 bytesdamienmckenna
#31 metatag-n2532588-31.patch8.2 KBdamienmckenna
#29 metatag-n2532588-29.interdiff.txt534 bytesdamienmckenna
#29 metatag-n2532588-29.patch8.2 KBdamienmckenna
#27 metatag-n2532588-27.patch8.19 KBdamienmckenna
#27 metatag-n2532588-27.interdiff.txt2.14 KBdamienmckenna
#25 metatag-n2532588-25.patch8.25 KBdamienmckenna
#19 metatag-n2532588-19.patch7.08 KBdamienmckenna
#15 metatag-add_new_meta_tags_fix_comment-2532588-15.patch7.08 KBrenatog
#12 metatag-add_new_meta_tags_fix_comment-2532588-12.patch816 bytesrenatog
#12 4) Img.png25.57 KBrenatog
#12 3) Img.png25.54 KBrenatog
#12 2) Img.png34.52 KBrenatog
#12 1) Img.png85.48 KBrenatog
#9 add_new_meta_tags-2532588-9.patch6.97 KBcebasqueira
#6 edit_add_new_meta_tags-2532588-6.patch6.64 KBcebasqueira

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add a new meta tag: Thumbnail » Add a new meta tags: Google CSE tags
Issue summary: View changes

I expanded the request to cover the other meta tags supported by Google CSE and not just the thumbnail.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add a new meta tags: Google CSE tags » Add new meta tags: Google CSE tags

I speek good.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
cebasqueira’s picture

cebasqueira commented
Assigned: Unassigned » cebasqueira
cebasqueira’s picture

cebasqueira commented
Assigned: cebasqueira » Unassigned
Status: Active » Needs review
StatusFileSize
new edit_add_new_meta_tags-2532588-6.patch6.64 KB
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Thanks for taking the time to put that together, I really appreciate it.

One thing that needs to be done slightly differently is the output - submodules should handle their own theming customizations, so the changes to theme_metatag() should go in the submodule.

cebasqueira’s picture

cebasqueira commented
Assigned: Unassigned » cebasqueira

Hi @DamienMcKenna,

You are right. I make the changes proposed and post a new patch!

Thanks my friend!

cebasqueira’s picture

cebasqueira commented
StatusFileSize
new add_new_meta_tags-2532588-9.patch6.97 KB
cebasqueira’s picture

cebasqueira commented
Assigned: cebasqueira » Unassigned
Status: Needs work » Needs review
renatog’s picture

renatog commented
Assigned: Unassigned » renatog
renatog’s picture

renatog commented
StatusFileSize
new 1) Img.png85.48 KB
new 2) Img.png34.52 KB
new 3) Img.png25.54 KB
new 4) Img.png25.57 KB
new metatag-add_new_meta_tags_fix_comment-2532588-12.patch816 bytes

I applyed the patch and works fine for me.

Follow bellow the images:

1) CMS:
1) Img

2) Tags:
1) Img

P.S. I found just one litle adjust, one comment with name "Facebook" in file: metatag_google_cse.install:

1) Img

I fixed it:
1) Img

The patch with Fix follow in attachement.

The rest are ok.

Regards

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

@renatog: Your patch only contains the changes to metatag_views_tests.views_default.inc, would you mind recreating the patch with your additional fix? Thanks.

renatog’s picture

renatog commented
Status: Needs work » Needs review
StatusFileSize
new metatag-add_new_meta_tags_fix_comment-2532588-15.patch7.08 KB

It is true. You're right @DamienMcKenna. Excuse me.

The new patch is attached.

Thank you very much.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thanks. I'll take a look at the patch this week.

renatog’s picture

renatog commented

Great!

Thanks.

cebasqueira’s picture

cebasqueira commented
Status: Needs review » Reviewed & tested by the community
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new metatag-n2532588-19.patch7.08 KB

This adds a README.txt file.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2758749: Plan for Metatag 7.x-1.18 release

Lets add this to the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks everyone!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Fixed » Patch (to be ported)

Needs to be ported to D8.

renatog’s picture

renatog commented
Issue tags: +ciandt-contrib
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new metatag-n2532588-25.patch8.25 KB

Ported to D8.

Status: Needs review » Needs work

The last submitted patch, 25: metatag-n2532588-25.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2532588-27.interdiff.txt2.14 KB
new metatag-n2532588-27.patch8.19 KB

Fixed the tests and plugins.

Status: Needs review » Needs work

The last submitted patch, 27: metatag-n2532588-27.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2532588-29.patch8.2 KB
new metatag-n2532588-29.interdiff.txt534 bytes

Should fix the errors.

Status: Needs review » Needs work

The last submitted patch, 29: metatag-n2532588-29.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2532588-31.patch8.2 KB
new metatag-n2532588-31.interdiff.txt575 bytes

Fixed the last error.

  • DamienMcKenna committed cc10a47 on 8.x-1.x 
    Issue #2532588 by DamienMcKenna, renatog, cebasqueira: Added the Google...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Related issues: +#2829190: Plan for Metatag 8.x-1.0-beta12

Committed.

  • DamienMcKenna committed c075fd7 on 8.x-1.x 
    Issue #2532588 by DamienMcKenna: Follow-up to fix the group assignment...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.