There is issue with "H" format for the options in a "hours" select box.

CommentFileSizeAuthor
#5 date-2532282-5.patch2.48 KByoftahe.addweb
#3 date-fix_join_array_in_sql-2532282-3.patch2.46 KBAndrey Baranov
#1 date-fixes_hours_format-2532282-1.patch866 bytesAndrey Baranov

Comments

Andrey Baranov’s picture

Andrey Baranov commented
Status: Active » Needs review
StatusFileSize
new date-fixes_hours_format-2532282-1.patch866 bytes
Andrey Baranov’s picture

Andrey Baranov commented
Status: Needs review » Active

There is an issue with incorrect value in a WHERE clause. When value is an array it is sent in a SQL as result of array.join() function

Andrey Baranov’s picture

Andrey Baranov commented
Status: Active » Needs review
StatusFileSize
new date-fix_join_array_in_sql-2532282-3.patch2.46 KB

Here is an issue

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Minor » Normal
Status: Needs review » Needs work

The patch needs a little work to match the Drupal coding standards, specifically the "else" statements should be on new lines. Additionally, it'd be useful to add some comments to explain why the logic is necessary.

yoftahe.addweb’s picture

yoftahe.addweb commented
Status: Needs work » Needs review
StatusFileSize
new date-2532282-5.patch2.48 KB

@DamienMcKenna, Please find my patch to resolve the coding standard issues. Hope this helps you!..

Thanks.