So this includes increased coverage, some cleanups (remove unused code) and fixes a bug when running in PHP 7.
It turns out that the sort order when uasort matches 2 strings is undefined. For unclear reasons (probably weird implementation) 5.x swaps the values where PHP 7 and HHVM do not. http://3v4l.org/e6noO
We are not really testing that equal strings behave a specific was but that our sorting works so I expanded the tests to match several cases that mostly cover different ordering of permissions.
| Issue category | Bug because if fixes a test failure in PHP 7 |
|---|---|
| Issue priority | Major because PHP 7 support is major? |
| Unfrozen changes | Unfrozen because it only changes tests. Additionally fixes failures for PHP 7 testing. |
| Disruption | Should be none. Tests only. |
| Comment | File | Size | Author |
|---|---|---|---|
| improve_PermissionHandlerTests-testBuildPermissionsSortPerModule.patch | 2.69 KB | neclimdul |
Comments
Comment #1
neclimdulComment #2
dawehner+1
Comment #3
alexpottCommitted 7a099e8 and pushed to 8.0.x. Thanks!