Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Lots of test fails in migration on PHP 7 due to the Null destination.
I initially thought it was a new class but I guess we just weren't using.
Proposed resolution
Rename to NullDestination, leave everything as-is (e.g. id in the annotation).
Remaining tasks
User interface changes
API changes
Class is renamed, but it's a plugin and guess mostly used for tests, so I don't think it needs to be a critical.
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#7 | null_migrate-2531028-7-interdiff.txt | 904 bytes | Berdir |
#7 | null_migrate-2531028-7.patch | 904 bytes | Berdir |
#1 | null_migrate-2531028-1.patch | 675 bytes | neclimdul |
Comments
Comment #1
neclimdulI forgot to file this apparently. Phenaproxima suggested DevNull and chx suggested Sarlacc.
Here is a patch that renames it to NullDestination though which is probably a safer choice. We shouldn't have to touch anything else because the plugin name is fine and will still resolve.
Comment #2
benjy CreditAttribution: benjy at CodeDrop commentedI don't mind NullDestination but it is a bit of inconsistency, it's now the only destination with the "Destination" suffix on the class name. How about a DoNotSave destination?
Comment #3
jibranFile description also needs an update.
Comment #4
rajeevkComment #5
BerdirNo strong opinion on the classname, just suggested NullDestination because it is a common pattern to name classes after what they are. In fact, our coding/naming standards would even require us to do exactly that.
Comment #6
benjy CreditAttribution: benjy at CodeDrop commentedMaybe we should rename the others then?
Comment #7
BerdirNot sure, certainly not here I think :)
IMHO, this rename is perfectly in line with similar changes we made for PHP7, for example renaming the typed data String class to StringData. We also didn't rename all of those to ..Data.
Comment #8
benjy CreditAttribution: benjy at CodeDrop commentedOK, that's fine by me.
Comment #9
alexpottCommitted f5cdc33 and pushed to 8.0.x. Thanks!