Problem/Motivation

Was researching how to do this until I found this module, one difference I found from the docs was the structure of the transaction.

The docs point to doing it this way with an actionField:
https://developers.google.com/tag-manager/enhanced-ecommerce#purchases

dataLayer.push({
  'ecommerce': {
    'currencyCode': 'USD',
    'purchase': {
      'actionField': {
        'id': 'ORDERNUMBER',
        'revenue': '32.00',
        'tax':'0',
        'shipping': '0',
        'coupon': 'FREESHIPPING'
      },
      'products': [
        {
          'name': 'Masque',
          'id': 'SKU',
          'price': '32.00',
          'category': 'Masques',
          'variant': 'Retail',
          'quantity': 1
        }
      ]
    }
  }
});

Proposed resolution

Wondering if it should change or maybe a checkbox to toggle between the two. FWIU it may be related to that "enhanced ecommerce" bit.

Remaining tasks

  1. Create patch
  2. Review patch
  3. Commit

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 interdiff.txt4.25 KBjoelpittet
#5 administration.png103.41 KBparisek
#5 allow_enhanced-2529278-5.patch6.69 KBparisek
#3 allow_enhanced-2529278-3.patch5.44 KBjoelpittet
#2 allow_enhanced-2529278-2.patch5.44 KBjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: GTM data format » Allow Enhanced Ecommerce format
Issue summary: View changes

Ok it's actually a subtly different format:
http://www.simoahava.com/analytics/ecommerce-tips-google-tag-manager/#tip5

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new allow_enhanced-2529278-2.patch5.44 KB

Here's what I was thinking. Let me know if this is something you'd be keen on including in your module or not?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new allow_enhanced-2529278-3.patch5.44 KB

Whoops a typo in that one, ; vs ,

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

This should be good now;)

parisek’s picture

parisek
Primary language Czech
commented
StatusFileSize
new allow_enhanced-2529278-5.patch6.69 KB
new administration.png103.41 KB

joelpittet: Thank you for your contribution, I made few changes to better inform administration users about configuration possibilities, please review.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new interdiff.txt4.25 KB

Here is an interdiff between the two help review the changes.
@see https://www.drupal.org/documentation/git/interdiff

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented 
+++ b/commerce_google_tag_manager.module
@@ -97,11 +96,11 @@ function commerce_google_tag_manager_ecommerce_js($order) {
-  $order_number = $order->order_number->value() ?: $order_id;
+  $order_number = $order->order_number->value() ? $order->order_number->value() : $order_id;

Personal preference?

These changes look good:) THanks

parisek’s picture

parisek
Primary language Czech
commented

Sorry I forgot interdiff :)

I don't know this shorthand version of ternary operator, but it's PHP 5.3+ thing and Drupal 7 requirement is PHP 5.2.5 or higher so I keep it old way.

  • parisek committed 4fd63d4 on 7.x-1.x authored by joelpittet 
    Issue #2529278 by joelpittet, parisek: Allow Enhanced Ecommerce format
parisek’s picture

parisek
Primary language Czech
commented
Status: Needs review » Fixed
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Oh yeah people still care about 5.2 :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.