Issue:
Module cache the whole content of weather received by api, so the weather conditions label like "Chance of Rain", "Partly Cloudy", "Clear" etc.. are not being change when we switch to other language. That happens because of common caching for all language.

Solution:
This can be solved by individual caching for each language, by adding language code to cache_get param cid

CommentFileSizeAuthor
#1 wunderground_weather-translation-cache-2529186-1.patch1.35 KBmiteshmap

Comments

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new wunderground_weather-translation-cache-2529186-1.patch1.35 KB

Here's the patch which can solve this issue with a minor tweak in cache cid.

created at Coworks

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Version: 7.x-1.13 » 7.x-1.x-dev
Priority: Normal » Major
Status: Active » Needs review
miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Issue summary: View changes
jeroen_drenth’s picture

jeroen_drenth commented
Status: Needs review » Fixed

Thanks, miteshmap. Seems like a very good idea. Tested and commitred.

  • miteshmap authored 938eca5 on 7.x-1.x 
    Issue #2529186 by miteshmap: weather conditions title are not being...
miteshmap’s picture

miteshmap
Primary language Gujarati
commented

Thanks jeroen_drenth :)

jeroen_drenth’s picture

jeroen_drenth commented
Status: Fixed » Closed (fixed)