Broken assertion introduced in #2443679

Problem/Motivation

One of the test assertions introduced in #2443679: PostgreSQL: Fix taxonomy\Tests\TermTest to EntityQueryTest is tautologic, i.e. it will always pass, even if the underlying code is broken again.

EntityQueryTest::assertResult() works with $this->queryResults so in order for it to work correctly, you previously need to do $this->queryResults = $query->execute();. This is missed in one case. Because the assertion following this is identical to the previous assertion it passes, because it works with the previous query results.

Proposed resolution

Change the following lines (starting 225) in core/modules/system/src/Tests/Entity/EntityQueryTest.php:

    $query
      ->condition($group_blue)
      ->condition($group_red)
      ->sort('id')
      ->execute();

to

    $this->queryResults = $query
      ->condition($group_blue)
      ->condition($group_red)
      ->sort('id')
      ->execute();

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation