After upgrading from branch 7.x-1.x or even with fresh install, the tabs are not properly generated. Causing them to be duplicated.
Manage Fields (for product)
Manage Fields (for order)
Manage Displays (for product)
Manage Displays (for order)

These are showing up even I don't have recurring entities on the List page ("There are no recurring entities.")

CommentFileSizeAuthor
commerce_recurring_tabs.png384.55 KBjohnrosswvsu
#1 commerce_recurring_tabs.png266.65 KBjohnrosswvsu
#2 commerce_recurring-improvements-on-operations-menu-2524470-2.patch7.21 KBjohnrosswvsu
#3 commerce_recurring_tabs_fixed.png64.59 KBjohnrosswvsu
#6 interdiff.txt2.29 KBjohnrosswvsu
#6 commerce_recurring-improvements-on-operations-menu-2524470-6.patch5.83 KBjohnrosswvsu

Comments

johnrosswvsu’s picture

johnrosswvsu commented
StatusFileSize
new commerce_recurring_tabs.png266.65 KB
johnrosswvsu’s picture

johnrosswvsu commented
Assigned: Unassigned » johnrosswvsu
Status: Active » Needs review
Issue tags: +Configuration system
StatusFileSize
new commerce_recurring-improvements-on-operations-menu-2524470-2.patch7.21 KB

I am attaching a patch to address this issue. Please review.

johnrosswvsu’s picture

johnrosswvsu commented
StatusFileSize
new commerce_recurring_tabs_fixed.png64.59 KB

I am attaching screenshot of how it will likely look with Admin menu.

Kiendeleo’s picture

Kiendeleo commented

I can confirm I am having this error as well

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Needs work

Thanks for working on this!

Here's a review of the change, if you clean the unrelated things up, we can push it and fix this :)

  1. +++ b/commerce_recurring.module
@@ -62,7 +62,10 @@ function commerce_recurring_entity_info() {
-  return array('product', 'order');
+  return array(
+    'product' => t('Product'),
+    'order' => t('Order'),
+  );

    No reason to translate machine names 

  2. +++ b/commerce_recurring.module
@@ -591,7 +594,14 @@ function commerce_recurring_cron() {
-  $permissions = array();
+  $permissions = array(
+    'administer commerce_recurring types' => array(
+      'title' => t('Administer recurring entity types'),
+      'description' => t('Allows users to configure recurring entity types and their fields.'),
+      'restrict access' => TRUE,
+    ),
+  );

    Unrelated change, we can treat this in a separate issue 

  3. +++ b/commerce_recurring_ui/commerce_recurring_ui.info
@@ -4,7 +4,6 @@ package = Commerce (contrib)
-configure = admin/commerce/recurring-entities
+configure = admin/commerce/recurring-entities/types

    I think this is fine 

  4. +++ b/commerce_recurring_ui/commerce_recurring_ui.module
@@ -32,22 +53,53 @@ function commerce_recurring_ui_menu() {
+/**
+ * Implements hook_admin_menu_map().
+ */
+function commerce_recurring_ui_admin_menu_map() {

    We shouldn't be adding an admin menu integration

johnrosswvsu’s picture

johnrosswvsu commented
Assigned: johnrosswvsu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new commerce_recurring-improvements-on-operations-menu-2524470-6.patch5.83 KB
new interdiff.txt2.29 KB

It took me a while to come back and fix this but I was able to update my fix on the issue with the 4 items listed by @pcambra.

This is sans the coding standard, which I could also add if needed.

facine’s picture

facine commented
Status: Needs review » Reviewed & tested by the community

Hi, I've tested the patch and works fine.

Thanks!

deggertsen’s picture

deggertsen commented
Status: Reviewed & tested by the community » Fixed

Looks good. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.