Demo article is not displayed on the front page

+++ b/client/src/Plugin/QueueWorker/CollectClientQueueWorker.php
@@ -245,12 +245,12 @@ class CollectClientQueueWorker extends QueueWorkerBase implements ContainerFacto
-      $message = $exception->getMessage();
+      $message = '';
       // Get a response.
       if ($response = $exception->getResponse()) {
+        $message = $this->parseResponse($response, 'message') ?: '';
         // In case of server error, suspend further handling of the queue.
         if ($response->getStatusCode()[0] == '5') {
-          $message = $this->parseResponse($response, 'message') ?: $message;
           throw new SuspendQueueException($message, 0, $exception);
         }

Same as (1) in https://www.drupal.org/node/2472479#comment-10082650.

This test is not actually tested (check test results). That's the reason why we get green tests.

1. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   + * @file
   + * Contains \Drupal\system\Tests\DrupalKernel\CollectDemoTest.
   + */
   

   Wrong path.

2. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   +
   +namespace Drupal\collect_demo\tests;
   +
   

   The namespace should be Drupal\collect_demo\Tests.

3. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   +    $this->assertText(t('collect:collectjson-definition/global/fields', array('@host' => $host)));
   

   The host parameter is not present here.

4. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   +    $this->clickLink(t('view'));
   

   View with capital "V".

5. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   +    $this->assertResponse('200');
   

   Http code should be passed as an integer.

6. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   +    $this->assertText(t('collect:collectjson/@host/entity/user"', array('@host' => $host)));
   

   Extra double quote character in 'collect:collectjson/@host/entity/user"'

7. +++ b/demo/src/Tests/CollectDemoTest.php
   @@ -0,0 +1,40 @@
   +    $this->clickLink(t('view'));
   +    $this->drupalGet('/');
   

   We don't really test anything here.

8. @@ -0,0 +1,40 @@
   diff --git a/src/Tests/CollectWebTest.php b/src/Tests/CollectWebTest.php
   index 9e4ad53..23903cc 100644
   
   --- a/src/Tests/CollectWebTest.php
   +++ b/src/Tests/CollectWebTest.php
   @@ -83,7 +83,6 @@ class CollectWebTest extends WebTestBase {
          'date' => (new DrupalDateTime('2014-12-16 09:40'))->getTimestamp(),
        ));
        $container->save();
   -
        $this->drupalGet('admin/content/collect');
        $this->assertResponse(403);
   

   Unrelated change?

Created an issue for broken ProcessingWebTest #2527148: Adding processors to the model is broken

The one of the reasons why CollectDemoTest failed is because CRM Core module is not on d.o (collect_demo has a dependency on it), so we cannot run the test properly...

I suggest to upload 2 patches, one with the leading change so we can commit that and the other one that will contain only CollectDemoTest (Named something like demo_article_not_displayed-2519966-12-DO-NOT-TEST.patch) so we can add the tests once CRM Core is on d.o.

P.S. We can still do "8" from the comment #8.

As #2527148: Adding processors to the model is broken is committed, Collect is green again. We can continue to work on this issue. Retesting...

Cool!

We can commit the patch, and continue to work on fixing CollectDemoTest locally.

Also, we can open an (postponed) issue (similar to #2430111: Re-add tests when CRM Core is on drupal.org) and upload fixed CollectDemoTest there.

Made some changes in CollectDemoTest. It should pass now with the patch #33 from #2535094: Schema missing when testing on collect_demo which depends on several modules.

Test is moved into #2430111: Re-add tests when CRM Core is on drupal.org so we can mark this issue as fixed.