Metatag values not saving correctly for Commerce entities

Please try updating to 1.6 and let me know how it goes.

FYI you shouldn't assign an issue to yourself unless you're actively working on it, which isn't applicable for this type of request.

Please help clarify exactly what you're doing - are these products being loaded through a view that is then displayed on a node page?

Ah, in that case It's kinda working by design - Metatag doesn't have any architecture to automatically load tags from entity A when you're viewing a completely unrelated page B.

What you could do is try using #2396693: Add Token support to insert values from the Views results to insert values from the Views results into Metatag:Views.

Argh! I've just reproduced this problem myself! Dangit.

Thanks for reporting the problem, I'll see about doing up a fix.

For some reason metatag_metatags_form_submit() isn't being triggered. Oh bother.

I'm (temporarily) moving this over to the Commerce issue queue to see if anyone might have suggestions as to what the problem is.

Could it be because the Product UI module's product edit form is wrapping another base product edit form? I'm not familiar with how the Metatag module alters forms to add its submit handlers.

@rszrama: Thanks for the update. I didn't have time to dig into Commerce much yet.

FYI Metatag uses a tag-team of metatag_field_attach_form() and metatag_form_alter() to add itself onto the entity form.

Hmm, ok, I'll check it out if I get a minute; are you checking for button level submit handlers vs. just using form level submit handlers?

Right now it's checking for form-level submit handlers, but I noticed that doing so means the Metatag form submission callback is never triggered.

Should we move this back to the Metatag queue then? I'm not sure what the general policy is for modules blanket altering other modules' forms, but I see two options:

1. Check to see if any submit elements in the form you're altering use button level submit handlers and alter Metatag's in there instead of the form level submit array, or
2. Wrap the form somehow to seed $form['#submit'] with your callback and then convince other modules to check for submit handlers in that array and append them to their button level submit arrays where appropriate.

If I'm not mistaken, there are places in Commerce where I've done that to preserve form level handlers in button level submit arrays.

I'm guessing the first option is more easily achievable, but it does depend on ensuring the button you're altering isn't a delete / cancel button. You can probably avoid that by checking to see if the button has #limit_validation_errors set on it, but you may also just depend on only altering the #submit arrays of submit elements actually named submit. That's a fairly strong pattern.

Moving the issue back to Metatag's queue.

I've updated the form handling to check for the alternative submission handler, that part works correctly now, but the bigger issue is that the $form_state['values']['metatags'] items aren't being added to the entity object, as happens with other entities. I suspect I need to do something with Entity API.

Bumping this to v7.x-1.8, sorry.

Hi Damien,

I added a separate submit handler for commerce product , and it's works fine for me. Here is the patch for I created based on it.

I've confirmed this worked. Yay! Thanks manikaprasanth!

This needed a little additional work to tidy it up.

A little more tweaking.

Committed.