In #2513626: [Regression] Module permission links missing from module list page, we discovered a system_test.permissions.yml file in core/modules/system/tests/modules/system_test/src that was added in #2464659: Routes that are varied by the 'user.permissions' cache context for anonymous users must also get the anonymous Role's cache tag. Permissions YAML files don't belong in "src" directories -- the permissions.yml file should be located in the module's root directory. The tests relying on those permissions still pass because the testing process doesn't actually require it.

If it is removed and tests pass, it is not needed.

CommentFileSizeAuthor
#2 2517114-2.patch406 bytesjoshi.rohit100

Comments

cilefen’s picture

Title: Remove wrongly placed system_test.permissions.yml file » Remove needless, wrongly-placed system_test.permissions.yml file
Issue summary: View changes
Status: Postponed » Active
Issue tags: +Quick fix
joshi.rohit100’s picture

Status: Active » Needs review
StatusFileSize
new406 bytes

Removed.

naveenvalecha’s picture

Status: Needs review » Reviewed & tested by the community

RTBC if green, this one because the permission is not using anywhere else.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch here too!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed d7f1914 on 8.0.x
    Issue #2517114 by joshi.rohit100, cilefen: Remove needless, wrongly-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.