Hi, I'm trying to upgrade to OpenAtrium 7.x-2.42 (from version 7.x-2.41), but the upgrade db updates for two modules aren't applying...

The following updates returned messages
fieldable_panels_panes module

Update #7108
Failed: DatabaseSchemaObjectExistsException: Table fieldable_panels_pane_type already exists. in DatabaseSchema->createTable() (line 657 of /var/www/vhosts/intranet.synberc.org/dev/includes/database/schema.inc).

and

og_vocab module

Update #7104
Failed: DatabaseSchemaObjectExistsException: Table og_vocab_vocab already exists. in DatabaseSchema->createTable() (line 657 of /var/www/vhosts/intranet.synberc.org/dev/includes/database/schema.inc).

For fieldable_panel_panes, I found this closed issue which looks like the same db update problem:https://www.drupal.org/node/1618308 - I tried applying the patch in comment #82, but application failed, likely because I'm trying to apply it to the latest stable release when the patch is intended for the Dev branch. I updated this issue with my findings but was advised to report it here.

I'm not sure what to do in this case. Do I upgrade this module (fieldable_panel_panes) to the dev release and then apply the patch? That is what I would normally do, but this module is part of the OpenAtrium distro, so I'm not sure. I see there is a OA 7.x-2.43 expected soon, possibly tomorrow - so if I upgrade to Dev and then patch, it will just get overwritten when I do the next upgrade.

I haven't searched the queues/web for the og_vocab error yet - will focus on that next.

Other than these 2 update failures, the site seems to be working well.

Anne

Comments

banoodle’s picture

Issue summary: View changes
mpotter’s picture

Category: Bug report » Support request
Priority: Critical » Normal

Are you sure you followed the Upgrade procedure linked in the release notes? We've updated dozens of sites and never seen those issues. You should *not* be updating individual modules yourself. You need to save your sites directory, then replace your entire drupal root directory with the new version, then restore your sites directory and then run update.php.

At this point you are going to need to revert your database to a backup from before the upgrade. Trying to fix your broken site is going to require some pretty hard work and still might leave your site in a weird state.

banoodle’s picture

Title: Some db updates for contrib modules in OA 7.x-2.42 are failing (fieldable_panel_panes and oa_vocabulary) » Some db updates for contrib modules in OA 7.x-2.42 are failing (fieldable_panel_panes and og_vocab)
Issue summary: View changes

Updating issue - I was wrongly referring to the second module update as OA_vocabulary but it is actually called og_vocab - sorry about that.

banoodle’s picture

@mpotter - thanks for the speedy response! Yes - I did follow the instructions at https://www.drupal.org/node/2321627 as advised. This method has worked on the many upgrades of OA I have performed in the past.

I will take your advice and start from the beginning again. I will update this issue with my results. However, I have already done 2 complete attempts with the same outcome, so I'm not super-optimistic.

banoodle’s picture

Sorry, another question for you @mpotter: how important is it for all OA modules to be enabled before you start the upgrade. We do disable some modules we're not actively using - could that be what's causing me pain?

mpotter’s picture

At that point you might be on your own based on what you have changed on the site. Those tables mentioned in the errors all already exist and should not be getting recreated unless there is something messed up.

If you are using memcache or some other caching layer, be sure to disable that during updates also. That can sometimes interfere.

mpotter’s picture

It's possible there is an issue with a module being disabled. I typically just update normal Atrium sites that haven't disabled anything. Keep in mind that Drupal is a bit weird and *does* run update hooks within disabled modules. That can sometimes cause weird problems.

Also, you don't typically need to actually disable modules. Just not using features you don't need is good enough. The performance decrease from having extra modules enabled is very minimal these days.

banoodle’s picture

Status: Active » Closed (cannot reproduce)

@mpotter - you were right - this was a problem with my environment. I think the permissions on my Dev environment are wrong.

I finally used git to pull the upgrade up to my Test environment and then everything worked well there (because git is ensuring the right permissions).

Sorry! Closing (cannot reproduce). Will fix my Dev site so I don't do this again.

Thanks for your help!