CommentFileSizeAuthor
#1 add_composer_json-2514574-1.patch323 bytestimmillwood

Comments

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new add_composer_json-2514574-1.patch323 bytes
naveenvalecha’s picture

naveenvalecha
He/Him
commented

I would love to RTBC this one. The composer.json does not create any dependencies ?

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

@naveenvalecha There are no dependencies, all this does is define the package and set the site as "drupal-module".

naveenvalecha’s picture

naveenvalecha
He/Him
commented

@timmillwood ,
Fine,RTBC +1 BUT AFAIK currently drupal.org package manager not using composer to automatically detect dependencies ?
Not doing RTBC as I am not sure

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

Right drupal.org package manager isn't using composer to automatically detect dependencies, and it shouldn't.

wundo’s picture

wundo commented
Status: Needs review » Fixed

I don't think there is much to review here, thanks for the patch ;)

wundo’s picture

wundo commented

  • wundo committed 9b49f9a on 8.x-1.x authored by timmillwood 
    Issue #2514574 by timmillwood, wundo: Add composer.json
naveenvalecha’s picture

naveenvalecha
He/Him
commented

yupeeee nice Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 1: add_composer_json-2514574-1.patch, failed testing.

Status: Needs work » Needs review

isntall queued 1: add_composer_json-2514574-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: add_composer_json-2514574-1.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Closed (fixed)