Problem/Motivation

migrate_drupal provides an implementation of Migrate's MigratePluginManager, but as far as I can tell, its one overridden method is never called by anything. So the entire class is pointless, as is the overridden method in the base class.

Proposed Resolution

Remove the useless class and Migrate's unused plugin manager method.

API Changes

migrate_drupal no longer provides its own plugin manager; it uses Migrate's instead. The removed method is protected, so it shouldn't really affect anything.

Comments

phenaproxima’s picture

Issue summary: View changes
phenaproxima’s picture

Priority: Normal » Minor
Issue tags: +API clean-up

Definitely a minor issue, since this is just cleanup.

Status: Needs review » Needs work

The last submitted patch, migrate_drupal-plugin_manager.patch, failed testing.

phenaproxima’s picture

Status: Needs work » Needs review
StatusFileSize
new3.33 KB

Thanks, testbot! Let's try again...

mikeryan’s picture

Status: Needs review » Reviewed & tested by the community

Clean all the things!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Migrate is not frozen in beta. Committed 2d9e1c5 and pushed to 8.0.x. Thanks!

  • alexpott committed 2d9e1c5 on 8.0.x
    Issue #2514052 by phenaproxima: Remove migrate_drupal's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.