Currently, the code is full of tab-characters, trailing spaces, inconsistent indentations, HTML in translatable strings, etc.

Pareview reports hunderds of errors: http://pareview.sh/pareview/httpgitdrupalorgprojectadminimaladminmenugit

I'm marking this as 'critical' as it prevents us from submitting patches.

CommentFileSizeAuthor
#7 fix_code_standard_issues-2513984-7.patch18.5 KBjoelpittet
#3 adminimal_admin_menu-fix_codestyle_issues-2513984.patch320.5 KBfortis

Comments

  • ANDiTKO committed 156f856 on 7.x-1.x 
    Fixes and visual updates

* Fixed Search box height. #2133109
* Fixed...
fortis’s picture

fortis commented
Assigned: Unassigned » fortis
fortis’s picture

fortis commented
StatusFileSize
new adminimal_admin_menu-fix_codestyle_issues-2513984.patch320.5 KB

I'll try to help, I fixed code style issues and 'TRUE' strings

fortis’s picture

fortis commented
Assigned: fortis » Unassigned
Status: Active » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Fix code style issues » Fix code standard issues
Status: Needs review » Needs work

Looks like this no longer applies.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

To do a quick fix we could just run:
phpcbf --standard=Drupal --ignore="js/slicknav/*" .
or manually with:
phpcs --standard=Drupal --ignore="js/slicknav/*" .

If you have code sniffer setup with the Drupal. https://www.drupal.org/node/1419988

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new fix_code_standard_issues-2513984-7.patch18.5 KB

This may not cover all the things @fortis covered but it gets a bit of a smaller jumpstart.

@fortis feel free to add to it.

Status: Needs review » Needs work

The last submitted patch, 7: fix_code_standard_issues-2513984-7.patch, failed testing.

  • Tessa Bakker committed de7ca26 on 7.x-1.x 
    Issue #2513984 by fortis, joelpittet, Tessa Bakker: Fix code standard...

  • Tessa Bakker committed e40001c on 7.x-1.x 
    Issue #2513984 by Tessa Bakker: Fix code standard issues
tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs work » Fixed
tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Fixed » Closed (fixed)