User edit form status radio buttons empty if user status is blocked

user status, used as #default_value in the radio element, is checked using \Drupal\user\UserInterface::isActive() which return a boolean.
Comment in \Drupal\Core\Render\Element\Radios::processRadios() say:

// Use default or FALSE. A value of FALSE means that the radio button is
// not 'checked'.
'#default_value' => isset($element['#default_value']) ? $element['#default_value'] : FALSE,

this is a little weird..if user account is blocked (status == FALSE) the default value is not considered

I think we need some tests..

What: Verified for Blocked user's status.
Result: "Blocked" status is appearing for the blocked user)screenshot attached).

Nice test coverage.

+++ b/core/modules/user/src/AccountForm.php
@@ -200,7 +200,10 @@ public function form(array $form, FormStateInterface $form_state) {
-      '#default_value' => $status,
+      // Convert status to an integer is needed because the value FALSE means
+      // that the radio button is not 'checked'.
+      // @see \Drupal\Core\Render\Element\Radios::processRadios()
+      '#default_value' => (int) $status,

I think rather than doing the cast to int we should just use $account->get('status') instead of $account->isActive().

    if ($admin) {
      $status = $account->isActive();
    }
    else {
      $status = $register ? $config->get('register') == USER_REGISTER_VISITORS : $account->isActive();
    }

That way if the status system is extended by contrib to have other values they need to change less.

Addressing #8 but I don't think it is a real improvement. I think that if we want to allow contrib modules to extend status system in a comfortable way we should add getter and setter methods for status in user entity and create constants for active and blocked statuses. Currently we use (at least in AccountForm) a fragile (positional) logic for the management of this attribute

    $form['account']['status'] = array(
      '#type' => 'radios',
      '#title' => $this->t('Status'),
      '#default_value' => $status,
      '#options' => array($this->t('Blocked'), $this->t('Active')),<---POSITIONAL
      '#access' => $admin,
    );

failures seem unrelated to this issue, retesting

The patch looks good. It has

• A failing test only patch
• A combined patch that fixes the test
• Code is clean and all is good.

Add beta evaluation.

Committed efeb597 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation.