NodeViewController::view() takes the arguments of $view_mode and $langcode but does not use them.

I'm not sure what the test should be for this patch.

CommentFileSizeAuthor
#1 2513332-node-view.patch695 bytesstevector

Comments

stevector’s picture

stevector
he/him
commented
StatusFileSize
new 2513332-node-view.patch695 bytes
stevector’s picture

stevector
he/him
commented
Status: Active » Needs review

hchonov queued 1: 2513332-node-view.patch for re-testing.

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
Component: render system » node system
Assigned: stevector » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

At the moment NodeViewController::view is used for the route entity.view.cannonical and has default arguments for the view mode and the language, but does not forward them to EntityViewController::view, which makes it imposible for contrib modules, to reuse the controller for custom view modes and languages.

The supplied patch does not need a test from my POV, thus I am setting it to RTBC.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

RTBC+1 — super simple fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7365cd4 and pushed to 8.0.x. Thanks!

  • alexpott committed 7365cd4 on 8.0.x 
    Issue #2513332 by stevector: NodeViewController::view() does not pass...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.