Hey guys,

your project has some files with wrong line endings.
According to the Drupal coding standards all projects must have LF (Linux) line endings not CRLF (Windows) ones.

I guess, and I really ONLY guess, that it could also be the reason why the automatic testing fails sometimes.
It led to an invalid patch created by `git format-patch` at least with me.

Check this article to find out how to properly set up your git to help you out with line endings: https://help.github.com/articles/dealing-with-line-endings/

I will add a patch that ONLY replaces line endings. Nothing else. You can confirm that by doing a diff ignoring line endings (--ignore-space-at-eol).

Have fun and merge fast, please.

func0der

CommentFileSizeAuthor
#5 field_group-proper_line_endings_7.x-1.4-2512618-5-do-not-test.patch111.08 KBtien.xuan.vo
#3 field_group-proper_line_endings_7.x-1.4-2512618-3.patch111.08 KBtien.xuan.vo
#1 field_group-proper_line_endings-2512618-1.patch111.58 KBfunc0der

Comments

func0der’s picture

func0der commented
Status: Active » Needs review
StatusFileSize
new field_group-proper_line_endings-2512618-1.patch111.58 KB
func0der’s picture

func0der commented
Title: Proper line endings (Linux) » [PATCH] Proper line endings (Linux)
tien.xuan.vo’s picture

tien.xuan.vo commented
StatusFileSize
new field_group-proper_line_endings_7.x-1.4-2512618-3.patch111.08 KB

I got problems with this too. Here is the patch for 7.x-1.4. I just use dos2unix to convert all files in the project.

Status: Needs review » Needs work

The last submitted patch, 3: field_group-proper_line_endings_7.x-1.4-2512618-3.patch, failed testing.

tien.xuan.vo’s picture

tien.xuan.vo commented
StatusFileSize
new field_group-proper_line_endings_7.x-1.4-2512618-5-do-not-test.patch111.08 KB

Do not test 7.x-1.4 patch.

func0der’s picture

func0der commented

Hey @tien.xuan.vo

patches are created for the current development branches of the modules, because they could contain already made changes since the last release.

My patch is so to say for the same version as yours ;)

donquixote’s picture

donquixote commented

Yes please!

Note: It is nice to see people posting patches here.
Personally, I think the maintainer should simply fire up an IDE or some other tool to fix the line endings for the files that have this problem, commit, and be done with it.

  • zuuperman committed 5447a94 on 7.x-1.x authored by tien.xuan.vo 
    Issue #2512618 by tien.xuan.vo, func0der: [PATCH] Proper line endings (...
nils.destoop’s picture

nils.destoop commented
Status: Needs work » Fixed

The patch did not apply anymore as the main module file was already in LF. The remaining files are now also in LF.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.