Compatibility with Commerce Cart View Override [#2512610]

At the moment the module is not compatible with Commerce Cart View Override module(https://www.drupal.org/project/commerce_cart_view_override)
because module use a fix form_id "views_form_commerce_cart_form_default" for identify the cart view and some settings are not apply for my custom view cart.

Comment	File	Size	Author
#3	2512610-compatibility-views_cart_override-2.patch	1.42 KB	segi
#1	2512610-compatibility-views_cart_override-1.patch	845 bytes	segi

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

segi CreditAttribution: segi at Cheppers commented 26 June 2015 at 09:34

Component:	General	» Quantity module
Status:	Active	» Needs review

File	Size
2512610-compatibility-views_cart_override-1.patch	845 bytes

Here is my patch.

Comment #2

segi CreditAttribution: segi at Cheppers commented 26 June 2015 at 09:37

Issue summary:

View changes

Comment #3

segi CreditAttribution: segi at Cheppers commented 26 June 2015 at 11:07

File	Size
2512610-compatibility-views_cart_override-2.patch	1.42 KB

Ok, I missed something here is the updated patch.

Comment #4

5n00py CreditAttribution: 5n00py commented 27 June 2015 at 07:57

Can you post some form id's that commerce extra should handle?

Or way to reproduce this issue.

Comment #5

27 June 2015 at 08:19

5n00py committed 8c2e750 on 7.x-1.x authored by segi

Issue #2512610 by segi, 5n00py: Compatibility with Commerce Cart View...

Comment #6

5n00py CreditAttribution: 5n00py commented 27 June 2015 at 08:22

Status:

Needs review

» Fixed

Thank you for patch, I have been tested it, works perfectly.
Committed.

Comment #7

segi CreditAttribution: segi at Cheppers commented 27 June 2015 at 08:39

Yes, here it is a code snippet which gives back the option list for admin page, where you can choose the custom cart view.

<?php

foreach (views_get_all_views() as $view_name => $view) {
    if ($view_name != 'commerce_cart_form' && strpos($view_name, 'commerce_cart_form_') !== 0) {
      continue;
    }

    if ($view->base_table == 'commerce_order' && !empty($view->display['default']) &&
        !empty($view->display['default']->display_options['arguments'])) {

      $first_arg = reset($view->display['default']->display_options['arguments']);
      if (strpos($first_arg['id'], 'order_id') === 0) {
        $options[$view_name] = isset($view->human_name) ? check_plain($view->human_name) : $view_name;
      }
    }
  }

?>

So every views which start with the following machine name "commerce_cart_form_".

I hope it will help to you understand the problem.