Fix documentation in password hashing class

Thanks! This almost all looks like improvements to the docs. One minor problem:

+++ b/core/lib/Drupal/Core/Password/PhpassHashedPassword.php
@@ -95,7 +95,8 @@ protected function base64Encode($input, $count) {
   /**
-   * Generates a random base 64-encoded salt prefixed with settings for the hash.
+   * Generates a random base 64-encoded salt prefixed with settings for the
+   * hash.
    *

The beginning of a doc block is supposed to be a one line sentence, so this needs to be shortened rather than wrapped.

I suggest changing the end wording to "... with hash settings" instead of "with settings for the hash"?

Looks good ! Thanks

Looking good to me too!!

+1 for RTBC, thanks all!

We seem to have lost several cleanups from the original patch in #1 to #5 when making the change @jhodgdon suggested:

diff --git a/core/lib/Drupal/Core/Password/PhpassHashedPassword.php b/core/lib/Drupal/Core/Password/PhpassHashedPassword.php
index dc3aad5..2deaa24 100644
--- a/core/lib/Drupal/Core/Password/PhpassHashedPassword.php
+++ b/core/lib/Drupal/Core/Password/PhpassHashedPassword.php
@@ -44,7 +44,7 @@ class PhpassHashedPassword implements PasswordInterface {
   protected $countLog2;
 
   /**
-   * Constructs a new password hashing instance.
+   * Constructs a new phpass password hashing instance.
    *
    * @param int $countLog2
    *   Password stretching iteration count. Specifies the number of times the
@@ -62,11 +62,11 @@ function __construct($countLog2) {
    *
    * @param string $input
    *   The string containing bytes to encode.
-   * @param int $count
+   * @param Integer $count
    *   The number of characters (bytes) to encode.
    *
    * @return string
-   *   Encoded string.
+   *   Encoded string
    */
   protected function base64Encode($input, $count) {
     $output = '';
@@ -95,8 +95,7 @@ protected function base64Encode($input, $count) {
   }
 
   /**
-   * Generates a random base 64-encoded salt prefixed with settings for the
-   * hash.
+   * Generates a random base 64-encoded salt prefixed with hash settings.
    *
    * Proper use of salts may defeat a number of attacks, including:
    *  - The ability to try candidate passwords against multiple hashes at once.
@@ -119,11 +118,11 @@ protected function generateSalt() {
   /**
    * Ensures that $count_log2 is within set bounds.
    *
-   * @param int $count_log2
+   * @param integer $count_log2
    *   Integer that determines the number of iterations used in the hashing
    *   process. A larger value is more secure, but takes more time to complete.
    *
-   * @return int
+   * @return integer
    *   Integer within set bounds that is closest to $count_log2.
    */
   protected function enforceLog2Boundaries($count_log2) {
@@ -145,16 +144,16 @@ protected function enforceLog2Boundaries($count_log2) {
    * for an attacker to try to break the hash by brute-force computation of the
    * hashes of a large number of plain-text words or strings to find a match.
    *
-   * @param string $algo
+   * @param String $algo
    *   The string name of a hashing algorithm usable by hash(), like 'sha256'.
-   * @param string $password
+   * @param String $password
    *   Plain-text password up to 512 bytes (128 to 512 UTF-8 characters) to
    *   hash.
-   * @param string $setting
-   *   An existing hash or the output of $this->generateSalt(). Must be at least
-   *   12 characters (the settings and salt).
+   * @param String $setting
+   *   An existing hash or the output of $this->generateSalt().  Must be
+   *   at least 12 characters (the settings and salt).
    *
-   * @return string
+   * @return String
    *   A string containing the hashed password (and salt) or FALSE on failure.
    *   The return string will be truncated at HASH_LENGTH characters max.
    */
@@ -201,14 +200,11 @@ protected function crypt($algo, $password, $setting) {
   }
 
   /**
-   * Parses the log2 iteration count from a stored hash or setting string.
-   *
-   * @param string $setting
-   *   An existing hash or the output of $this->generateSalt(). Must be at least
-   *   12 characters (the settings and salt).
+   * Parse the log2 iteration count from a stored hash or setting string.
    *
-   * @return int
-   *   The log2 iteration count.
+   * @param String $setting
+   *   An existing hash or the output of $this->generateSalt().  Must be
+   *   at least 12 characters (the settings and salt).
    */
   public function getCountLog2($setting) {
     return strpos(static::$ITOA64, $setting[3]);

Let's add back those other cleanups? Thanks!

Interdiff to #1.

Oops!! My Bad!!!

Great, thanks for the quick update!

This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x. I added claudiu.cristea to the commit message as per #9.