See meta-issue: #2511554: [meta] Move some parts of Page Manager into CTools

After #2511556: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager is committed to CTools, we'll need to refactor Page Manager to use the CTools versions and remove the old code.

CommentFileSizeAuthor
#8 refactor_after-2511574-8.patch20.85 KBdsnopek
#3 refactor_after-2511574-3.patch28.04 KBmatthewmessmer

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Postponed

Postponed on #2511556: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager

matthewmessmer’s picture

matthewmessmer commented
Assigned: Unassigned » matthewmessmer
Status: Postponed » Active

Working on this at MWDS

matthewmessmer’s picture

matthewmessmer commented
Status: Active » Needs review
StatusFileSize
new refactor_after-2511574-3.patch28.04 KB

Adding patch that removes the files moved to ctools in https://www.drupal.org/node/2511556 and refactors necessary items to use the new ctools code.

Status: Needs review » Needs work

The last submitted patch, 3: refactor_after-2511574-3.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Postponed

Postponing on #2511556: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager - the tests won't pass via testbot until that is merged.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

That alone won't help.

Testbot is a bit slow with dependencies. You need a separate issue (or a separate patch in this issue) that *just* adds the ctools dependency, commit that and then give testbot some time to figure that out and update the dependency information (usually takes ~24h).

You might want to do that asap.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Ok, thanks! I've created a new issue for that #2551195: Add dependency on CTools.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new refactor_after-2511574-8.patch20.85 KB

Here's a new version of this patch with ConditionVariantInterface and ConditionVariantTrait added back per #2511556-13: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Postponed » Closed (fixed)

This has already been done in a couple other commits:

http://cgit.drupalcode.org/page_manager/commit/?id=c2f8bb5b0d629310e538f...

http://cgit.drupalcode.org/page_manager/commit/?id=4df812eaec77acd5b176b...