See meta-issue: #2511554: [meta] Move some parts of Page Manager into CTools

VariantCollection probably belongs in core. At our meeting EclipseGC said that Variants are probably the only plugin in core without a corresponding Collection. However, there is some discussion about having Variant config entities, that would make this code unnecessary for Page Manager.

But if we do need it, and we can't get it into core, then CTools is where it belongs!

CommentFileSizeAuthor
#4 2511558-add-VariantCollection-3.patch1.14 KBsaltednut

Comments

dsnopek’s picture

dsnopek’s picture

Title: Add Drupal\page_manager\Plugin\VariantCollection.php from Page Manager » Add Drupal\page_manager\Plugin\VariantCollection from Page Manager
saltednut’s picture

This seems to involve just moving the file and renaming some namespaces. I didn't see usage in page_manager where we'd also have to refactor, the file would just need to be removed.

It may make sense to roll these changes in with #2511560: Add Drupal\page_manager\Plugin\VariantAwareInterface and VariantCollection from Page Manager and #2550959: Remove VariantAwareInterface, ctools to provide VariantCollection and VariantCollectionInterface instead

saltednut’s picture

Status: Active » Needs review
StatusFileSize
new1.14 KB
saltednut’s picture

Status: Needs review » Postponed

Rather than doing this as a patch #2 for ctools and also open an issue and patch page_manager, we can move this stuff together.

dsnopek’s picture

Status: Postponed » Closed (duplicate)