Hi,
Problem:
Manual Crop by default takes the top row weight position when applying the effect to an image style no matter where it is set in the list.
Impact:
This prevents the ability to reorder it with other actions e.g. the 'define canvas' action from the ImageCache Actions module should allow the background canvas colour to be changed but needs to be applied first. However it cannot be set as the first action which it needs to be in order to apply the canvas colour. Being able to do this should help resolve the common issue raised on Drupal's default black canvas applied to cropped images but is being prevented by Manual Crop action defaulting to first action.
Solution:
Allow the Manual Crop row weight to be reordered with other actions.
Thanks for any help to get this resolved.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | force_effect_order-2511118-4.patch | 2.49 KB | jstoller |
Comments
Comment #1
matthijsThe reason that Manual Crop enforces itself to be the first effect is very simple: it must be sure that it's still dealing with the original image dimensions (otherwise funky crop results may occur).
If it would be allowed to apply other effects first, people will add scale effects and start complaining that the module doesn't work :-)
But maybe it's a good idea to add a setting to disable this behaviour on own risk?
Comment #2
caseyb commentedThanks for the super quick reply!!
Your logic makes sense and I can see why it has been applied. Your suggestion to add a setting would be a good solution and I'm sure appreciated by many users!!
Many thanks again!!
Comment #3
caseyb commentedComment #4
jstollerI ran into this same issue with the Image Replace module. The attached patch adds a new configuration variable to "Force Manual Crop effects to run first." The setting defaults to TRUE, so behavior will not change for existing installations. Unchecking that setting will bypass the manualcrop_force_effect_order() function.
Comment #6
matthijsPatch applied and committed, thanks!