Fix pubsubhubbub.

Howdy,

I applied the feeds-fix-push-2510260-11.patch to the lastest 7.x-2.x-dev and it said it applied cleanly. Then updated the database running update.php

I am still getting the same error I get with the 7.x-2.0-beta1 version.

Notice: Undefined property: stdClass::$data in PuSHSubscriber->request() (line 279 of /var/www/drupal/sites/all/modules/feeds/libraries/PuSHSubscriber.inc).

This is how set it up http://i.stack.imgur.com/0DTnI.jpg

I'm I doing something wrong?

I'm attaching an updated patch that addresses the issue mentioned in #12, and also adds some additional debug data in that place, as well as removes FeedsMissingPlugin::menuItem() and uses variable_get('cron_safe_threshold', DRUPAL_CRON_DEFAULT_THRESHOLD) to decide how far ahead to resubscribe to feeds – if the cron is run very seldom, then a feed could otherwise have its lease expire before the cron has time to resubscribe it.

Apart from mentioned fixes I have some feedback:

1. The lease is currently save as relative from the timestamp of a subscription rather than as an absolute timestamp. I believe an absolute timestamp would be better, and to then add an index on that column as well so that queries that just asks for expired subscriptions can use that index to get a quick and simple answer
2. Resubscribing to feeds one by one within the same cron run doesn't scale that much. It's better than nothing, but at least as a follow up issue it should be broken out into jobs that can span several cron runs.

@Voxpelli, thanks for working on a new patch, I tried your feeds-fix-push-2510260-13.patch, but now I am getting this error.

Notice: Undefined index: lease in PuSHSubscription::load() (line 392 of /var/www/drupal/sites/all/modules/feeds/plugins/FeedsHTTPFetcher.inc).

Drupal 7 reached end of life and the D7 version of Feeds is no longer being developed. To keep the issue queue focused on supported versions, we’re closing older D7 issues.

If you still have questions about using Feeds on Drupal 7, feel free to ask. While we won’t fix D7 bugs anymore, we’re happy to offer guidance to help you move forward. You can do so by opening (or reopening) a D7 issue, or by reaching out in the #feeds channel on Drupal Slack.

If this issue is still relevant for Drupal 10+, please open a follow-up issue or merge request with proposed changes. Contributions are always welcome!