One or more recent commit have broken the fragile tests. There may be more than one cause. Testbot seems to fail much sooner than drush test-run. I have trouble getting the tests to run via the UI without timeout, despite a long dev environment timeout and the batch API.

CommentFileSizeAuthor
#2 webform-webform_node_types_caching-2510216-2.patch1.86 KBdanchadwick

Comments

danchadwick’s picture

danchadwick commented
Priority: Normal » Major

The issue was that static caching was added to webform_node_types. Only during installation will the cache be stale. Tests execute module installation and node creation in the same session, so tests fail. The cache must be reset after installation to allow the tests to pass.

Still testing. There may be other issues too. I'm bumping the priority to Major, since other patches are contingent on getting tests working again.

danchadwick’s picture

danchadwick commented
Status: Active » Fixed
StatusFileSize
new webform-webform_node_types_caching-2510216-2.patch1.86 KB

Committed to 7.x-4.x

  • DanChadwick committed 89176dc on 7.x-4.x 
    Issue #2510216: Tests are failing due to static caching in...
danchadwick’s picture

danchadwick commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Priority: Major » Normal
Status: Fixed » Patch (to be ported)

Needs port to D8.

  • fenstrat committed af0e06d on 8.x-4.x 
    Issue #2510216 by DanChadwick: Tests are failing due to static caching...
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 8.x-4.x-dev » 7.x-4.x-dev
Priority: Normal » Major
Status: Patch (to be ported) » Fixed

Committed and pushed to 8.x-4.x.

Testing is still a long way from working on 8.x-4.x, but starting to work through the 7.x-4.x issues which needing porting and this needed porting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.