List items are printing with padding above them when they should not in the footer. With every menu item added the padding stacks and stacks so the footer menu look like stairs. See screenshot....
Fix the padding issue for all menus that currently exist and could be added in the footer.
Write a patch.
Code review of the patch.
Visual review of the patch.
Repeat if necessary
RTBC
Fixes a visual bug with menus in the footer.
None
None.
| Issue category | Bug because if you add menu items to a menu in the footer it does not look visually correct. |
|---|---|
| Issue priority | Not critical because the menu functions fine it's a visual bug. |
| Unfrozen changes | Unfrozen because it only changes CSS. |
| Disruption | Non disruptive it is a small CSS fix |
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | footer-menu-not-aglined--2509890-3.patch | 457 bytes | dom. |
| #3 | after-patch.png | 2.44 KB | dom. |
| #3 | before-patch.png | 2.45 KB | dom. |
| #3 | menu-vertical.png | 2.18 KB | dom. |
| #1 | Screen Shot 2015-06-22 at 19.33.25.png | 13.58 KB | saki007ster |
Comments
Comment #1
saki007sterComment #2
saki007sterComment #3
dom. commentedHum... Did patch in the meantime.
So, reviewing saki007ster, I disagree with your choice for it does impact *all* menu-items of the website. Any menu that would be displayed vertically for instance would loose their "vertical space".
Here is another patch proposal that impacts only menus in the footer.
Before patch:
After patch:
Comment #4
bill richardson commentedFixes issue in Bartik footer menu
Comment #5
emma.mariaThanks @Dom. that solution is great. RTBC++
Comment #7
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed e691335 and pushed to 8.0.x. Thanks!