Feeds module cannot find its parser module due to filesystem restriction [#2509464]

If PHP is configured to access files only within web directory, Feeds module cannot find its parser library and throws message:

Warning: file_exists(): open_basedir restriction in effect. File(/ParserCSV.inc) is not within the allowed path(s): ([...]\htdocs) in feeds_include_library() (line 984 of [...]\Htdocs\drupal\sites\all\modules\feeds\feeds.module).

As a consequence, after that not found library, system "imports" 1 totally empty node, and throws error
"PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry ..." - obviously, it is dublicate entry for next empty node(s).

configuration in php.ini about restricted filesystem access:
open_basedir = [directory]
; http://php.net/open-basedir

Windows Server. On test system, Windows too, but without setting open_basedir in php, importing works.

Comment	File	Size	Author
#19	feeds_module_cannot-2509464-19.patch	881 bytes	joelpittet
#19
#12	feeds-libraries-include-2509464-13.patch	2.78 KB	twistor
#12
#10	feeds-libraries-include-2509464-10.patch	2.77 KB	twistor
#10
#3	feeds-libraries-include-2509464-3.patch	924 bytes	twistor
#3
#1	feeds-libraries-include-2509464-1.patch	923 bytes	twistor
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

twistor CreditAttribution: twistor as a volunteer commented 21 June 2015 at 21:55

Status:

Active

» Needs review

File	Size
feeds-libraries-include-2509464-1.patch	923 bytes

It looks like the libraries module is not configured correctly. We should check for that and also support sites/all/libraries.

Comment #2

21 June 2015 at 21:58

Status:

Needs review

» Needs work

The last submitted patch, 1: feeds-libraries-include-2509464-1.patch, failed testing.

Comment #3

twistor CreditAttribution: twistor as a volunteer commented 21 June 2015 at 22:03

Status:

Needs work

» Needs review

File	Size
feeds-libraries-include-2509464-3.patch	924 bytes

Comment #4

22 June 2015 at 01:03

The last submitted patch, 1: feeds-libraries-include-2509464-1.patch, failed testing.

Comment #5

22 June 2015 at 04:37

twistor queued 3: feeds-libraries-include-2509464-3.patch for re-testing.

Comment #6

Max1 CreditAttribution: Max1 commented 22 June 2015 at 19:09

Wow, feeds-libraries-include-2509464-3.patch works like a charm!

Thank you

Comment #7

Max1 CreditAttribution: Max1 commented 22 June 2015 at 19:10

Status:

Needs review

» Fixed

Comment #8

Max1 CreditAttribution: Max1 commented 22 June 2015 at 19:11

Status:

Fixed

» Reviewed & tested by the community

Comment #9

Max1 CreditAttribution: Max1 commented 22 June 2015 at 19:12

I am the community :-)

Please integrate the patch to module for all.

Comment #10

twistor CreditAttribution: twistor as a volunteer commented 22 June 2015 at 19:49

Version:

7.x-2.0-alpha9

» 7.x-2.x-dev

File	Size
feeds-libraries-include-2509464-10.patch	2.77 KB

Glad to hear it helps.

There's another place this has to be fixed.

Comment #11

22 June 2015 at 19:52

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 10: feeds-libraries-include-2509464-10.patch, failed testing.

Comment #12

twistor CreditAttribution: twistor as a volunteer commented 22 June 2015 at 19:52

File	Size
feeds-libraries-include-2509464-13.patch	2.78 KB

oops.

Comment #13

twistor CreditAttribution: twistor as a volunteer commented 22 June 2015 at 21:03

Status:

Needs work

» Needs review

Comment #14

23 June 2015 at 05:08

twistor committed 583e6c1 on 7.x-2.x

Issue #2509464 by twistor, Max1: Feeds module cannot find its parser...

Comment #15

twistor CreditAttribution: twistor as a volunteer commented 23 June 2015 at 05:10

Status:

Needs review

» Fixed

3 files were hidden/shown/deleted

File	Size
feeds-libraries-include-2509464-1.patch	923 bytes

feeds-libraries-include-2509464-3.patch	924 bytes

feeds-libraries-include-2509464-10.patch	2.77 KB

Comment #16

joelpittet

English

Vancouver

CreditAttribution: joelpittet commented 23 June 2015 at 18:21

@twistor This seemed to throw some new errors after it was upgraded to latest dev this morning.

Notice: Undefined variable: path in feeds_library_exists() (line 1151 of /feeds/feeds.module).
Notice: Undefined variable: path in feeds_library_exists() (line 1151 of /feeds/feeds.module).
Notice: Undefined variable: path in feeds_library_exists() (line 1151 of /feeds/feeds.module).
Notice: Undefined variable: path in feeds_library_exists() (line 1151 of /feeds/feeds.module).

Comment #17

joelpittet

English

Vancouver

CreditAttribution: joelpittet commented 23 June 2015 at 18:26

Status:

Fixed

» Needs work

Unfortunately as much as we both would like assignment inside a condition to be in scope and early shortcut, this doesn't seem to work:

Here's sample to see:
http://3v4l.org/BHISv

Comment #18

joelpittet

English

Vancouver

CreditAttribution: joelpittet commented 23 June 2015 at 18:57

This may be a better fix with no performance hit perse

http://3v4l.org/FjC7i

Comment #19

joelpittet

English

Vancouver

CreditAttribution: joelpittet commented 23 June 2015 at 19:26

Status:

Needs work

» Needs review

File	Size
feeds_module_cannot-2509464-19.patch	881 bytes

Try this.

Comment #20

23 June 2015 at 19:51

twistor committed 94a29ed on 7.x-2.x authored by joelpittet

Issue #2509464 by twistor, joelpittet: Feeds module cannot find its...

Comment #21

twistor CreditAttribution: twistor as a volunteer commented 23 June 2015 at 19:51

Status:

Needs review

» Fixed

Oy, missing some parens I suppose. We should have libraries enabled on testbot.

fixed feeds_include_library() as well.

Comment #22

Max1 CreditAttribution: Max1 commented 23 June 2015 at 20:46

I have updated Feeds module to last dev version (just to be accurate, last hour version - what a speed!). It works great on restricted php, and imports nodes from csv without errors.