By default in the VBO theme_views_bulk_operations_confirmation($variables) function has strong tag in the output:
$output = theme('item_list', array('items' => $items, 'title' => t('You selected the following <strong>!count</strong>:', array('!count' => $count))));
But not all themes have the same logic for 'theme_item_list' input parameters. E.g. in the bootstrap theme strong tag doesn't correctly display, because 'title' should be an array for including HTML. For correct displaying output should be:
$output = theme('item_list', array('items' => $items, 'title' => array('text' => t('You selected the following <strong>!count</strong>:', array('!count' => $count)), 'html' => TRUE)));
So I offer to remove strong tag from default output. I think that instead of getting bug by default, developers should add this tag in correct way(in theme function theme_views_bulk_operations_confirmation($variables)) if it is necessary for them.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2508990-4.patch | 1001 bytes | joelpittet |
#1 | views_bulk_operations-fix-for-strong-tag-bootstrap-2508990-1.patch | 650 bytes | snap_x |
1193x226-e781.png | 12.25 KB | snap_x |
Comments
Comment #1
snap_xRemoved strong tag from function theme_views_bulk_operations_confirmation()
Comment #2
stupiddingo CreditAttribution: stupiddingo commentedWas seeing the same same behavior on bootstrap. This resolves it.
Comment #3
AswathyAjish CreditAttribution: AswathyAjish commentedThanks for the patch #1. It worked for me.
Comment #4
joelpittetHow about using
<em>
through the%count
? That is quite common and will escape the value correctly.Also there were two spots where
<strong>
was used, so I covered both in the patch.Comment #5
gdaw CreditAttribution: gdaw as a volunteer commentedPatch 4 works fine for our bootstrap site.
RTBC + 1
Comment #7
joelpittetThanks @gdaw, I've committed this to the latest -dev release.