Problem/Motivation

There is some extra markup in views ui above "Save" and "Cancel" buttons that was needed for views ui modals before #1851414: Convert Views to use the abstracted dialog modal.

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 after.png122.4 KBolli
#1 before.png133.65 KBolli
remove-views-ajax-area.patch1.39 KBolli
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

olli’s picture

olli CreditAttribution: olli commented
Issue summary: View changes
Priority: Normal » Minor
Related issues: +#2408525: Rewrite Views UI CSS inline with our CSS standards - Part 1
FileSize
before.png133.65 KB
after.png122.4 KB

It seems the CSS for these was removed in #2408525: Rewrite Views UI CSS inline with our CSS standards - Part 1.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented

Nohting here is used by the JS so it's safe to remove on my end.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +frontend

Yep. I can confirm there is no CSS that relies on this markup.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Dead code removal is permitted during beta. Committed 5e77cbe and pushed to 8.0.x. Thanks!

  • alexpott committed 5e77cbe on 8.0.x 
    Issue #2505965 by olli: Remove dead code related to old views ui modal

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.