Follow-up to #2422353: Comment module should check that comment body field exists

Problem/Motivation

Commend admin overview uses route names because that code was written before link templates introduced.

Proposed resolution

Use link templates to generate links

Remaining tasks

patch/review/commit

User interface changes

no

API changes

no

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because cleans code to current API
Issue priority Normal because clean-up newly introduced code
Disruption Non-disruptive
CommentFileSizeAuthor
comment-admin-url.patch1.79 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Great cleanup

Status: Reviewed & tested by the community » Needs work

The last submitted patch, comment-admin-url.patch, failed testing.

Status: Needs work » Needs review

andypost queued comment-admin-url.patch for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer commented
Status: Needs review » Reviewed & tested by the community

another bot flux

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Removing a call to a static method reduces fragility and this cleans up code we've introduced in d8. Committed 8584bcc and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation.

  • alexpott committed 8584bcc on 8.0.x 
    Issue #2505841 by andypost: Make CommentAdminOverview use link templates

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.