Dave Reid brought up the suggestion of doing away with the entity selection entirely and to just use the configurations to determine whether or not an entity is supported. The suggestion is that the presence of a global configuration for an entity would indicate support for that entity, which would even further simplify the logic that was added to v1.5.

The question is how to tell when the site builder wants to disable support for a specific bundle, e.g. one content type that the site builder doesn't want to support. I think some specific use cases need to be defined and then the logic & UI updated accordingly.

Comments

dave reid’s picture

Assigned: Unassigned » dave reid

I'd actually like to tackle this on.

damienmckenna’s picture

Not going to add this to the next release.

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new1.55 KB

Here's the first step. If I go in and disable the meta tag configuration for "Node" then I should not see any forms on nodes for editing meta tags.

Status: Needs review » Needs work

The last submitted patch, 3: 2505215-disable-metatag-config-and-forms.patch, failed testing.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new3.05 KB

This one changes the logic of metatag_entity_supports_metatags() to look at the config enable/disable state, instead of checking in metatag_metatags_form(). Also fixes metatag_metatag_config_instance_info() to now always return supported contexts.

Status: Needs review » Needs work

The last submitted patch, 5: 2505215-disable-metatag-config-and-forms.patch, failed testing.

dave reid’s picture

Tested a bit more logic and scenarios. Next up, removing all the specific entity type and bundle checkboxes/variables that are no longer necessary.

dave reid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 2505215-disable-metatag-config-and-forms.patch, failed testing.

dave reid’s picture

StatusFileSize
new8.17 KB
new4.41 KB

Starting to hack away at the existing variable code, and fixing tests.

dave reid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: 2505215-disable-metatag-config-and-forms.patch, failed testing.

dave reid’s picture

StatusFileSize
new22.36 KB
new8.17 KB

Wrong patch, but correct interdiff...

dave reid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: 2505215-disable-metatag-config-and-forms.patch, failed testing.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new22.75 KB
new1.83 KB

Another try at passing tests.

dave reid’s picture

Status: Needs review » Needs work

The last submitted patch, 16: 2505215-disable-metatag-config-and-forms.patch, failed testing.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new24.1 KB

Trying to work out a caching issue with tests, otherwise this is working as expected.

@DamienMcKenna: Mind taking a look at this? This is how I envisioned "enabling or disabling" support for metatags per entity type originally, just by inspecting the config entities.

Status: Needs review » Needs work

The last submitted patch, 19: 2505215-disable-metatag-config-and-forms.patch, failed testing.

damienmckenna’s picture

I'd prefer to do a plumbing change like this on a smaller release, so lets pull it from for 1.8 (so it can go out as soon as the i18n support is fixed) and review it for 1.9.

dave reid’s picture

Priority: Normal » Major

Bumping priority. I never envisioned having a wall of checkboxes in addition to the config system. They really need to be unified.

dave reid’s picture

@DamienMcKenna: Can we talk about moving forward with a plan for this?

damienmckenna’s picture

@Dave Reid: Ping me on IRC tomorrow?

damienmckenna’s picture

It needs a reroll, then we can work on the tests.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new24.42 KB

Fixed merge conflict.

Status: Needs review » Needs work

The last submitted patch, 26: 2505215-disable-metatag-config-and-forms.patch, failed testing.

The last submitted patch, 26: 2505215-disable-metatag-config-and-forms.patch, failed testing.

damienmckenna’s picture

Issue tags: +Needs usability review
damienmckenna’s picture

yoroy’s picture

Not sure what to review here. Issue summary is a bit too sparse to understand what the before/after might be for the interface.

damienmckenna’s picture

Assigned: dave reid » Unassigned
bluegeek9’s picture

Status: Needs work » Closed (outdated)
Issue tags: -Usability
//www.flaticon.com/free-icons/thank-you Thank you for your contribution!
Unfortunatly Drupal 7 is no longer supported. We encourage you to upgrade to a modern version of Drupal.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.