Closed (outdated)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Jun 2015 at 13:45 UTC
Updated:
29 Sep 2026 at 20:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dave reidI'd actually like to tackle this on.
Comment #2
damienmckennaNot going to add this to the next release.
Comment #3
dave reidHere's the first step. If I go in and disable the meta tag configuration for "Node" then I should not see any forms on nodes for editing meta tags.
Comment #5
dave reidThis one changes the logic of metatag_entity_supports_metatags() to look at the config enable/disable state, instead of checking in metatag_metatags_form(). Also fixes metatag_metatag_config_instance_info() to now always return supported contexts.
Comment #7
dave reidTested a bit more logic and scenarios. Next up, removing all the specific entity type and bundle checkboxes/variables that are no longer necessary.
Comment #8
dave reidComment #10
dave reidStarting to hack away at the existing variable code, and fixing tests.
Comment #11
dave reidComment #13
dave reidWrong patch, but correct interdiff...
Comment #14
dave reidComment #16
dave reidAnother try at passing tests.
Comment #17
dave reidComment #19
dave reidTrying to work out a caching issue with tests, otherwise this is working as expected.
@DamienMcKenna: Mind taking a look at this? This is how I envisioned "enabling or disabling" support for metatags per entity type originally, just by inspecting the config entities.
Comment #21
damienmckennaI'd prefer to do a plumbing change like this on a smaller release, so lets pull it from for 1.8 (so it can go out as soon as the i18n support is fixed) and review it for 1.9.
Comment #22
dave reidBumping priority. I never envisioned having a wall of checkboxes in addition to the config system. They really need to be unified.
Comment #23
dave reid@DamienMcKenna: Can we talk about moving forward with a plan for this?
Comment #24
damienmckenna@Dave Reid: Ping me on IRC tomorrow?
Comment #25
damienmckennaIt needs a reroll, then we can work on the tests.
Comment #26
dave reidFixed merge conflict.
Comment #29
damienmckennaComment #30
damienmckennaComment #31
yoroy commentedNot sure what to review here. Issue summary is a bit too sparse to understand what the before/after might be for the interface.
Comment #32
damienmckennaComment #33
bluegeek9 commented