Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
An empty construct method is just a waste
Proposed resolution
Remove it.
Remaining tasks
User interface changes
API changes
Beta phase evaluation
| Issue category | Task because something that needs to be done |
|---|---|
| Prioritized changes | The main goal of this issue is performance |
I'm calling this a performance optimization, maybe it's a but far fetched, but there should be a very minor improvement removing an unneeded method, so why not do it.
If some one really feels like objecting, we can also wait 6 month for 8.1.x which seems a bit silly for this kind of minor cleanup.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mockfilefinder_has-2505193-1.patch | 939 bytes | googletorp |
Comments
Comment #1
googletorp CreditAttribution: googletorp commentedComment #2
almaudoh CreditAttribution: almaudoh commentedI'm not sure about performance since the gains may not be that much and would require profiling. However, this fix does reduce code fragility.
Comment #3
alexpottI think this was to keep it the same as
Doctrine\Common\Reflection\Psr0FindFilebut constructors are not part of the interface. Less code not doing anything is a good thing. And this is not disruptive at all. Removing dead code is allowable during beta. Committed 996325b and pushed to 8.0.x. Thanks!