Problem/Motivation

An empty construct method is just a waste

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because something that needs to be done
Prioritized changes The main goal of this issue is performance

I'm calling this a performance optimization, maybe it's a but far fetched, but there should be a very minor improvement removing an unneeded method, so why not do it.

If some one really feels like objecting, we can also wait 6 month for 8.1.x which seems a bit silly for this kind of minor cleanup.

CommentFileSizeAuthor
#1 mockfilefinder_has-2505193-1.patch939 bytesgoogletorp

Comments

googletorp’s picture

googletorp commented
Status: Active » Needs review
StatusFileSize
new mockfilefinder_has-2505193-1.patch939 bytes
almaudoh’s picture

almaudoh commented
Status: Needs review » Reviewed & tested by the community

I'm not sure about performance since the gains may not be that much and would require profiling. However, this fix does reduce code fragility.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I think this was to keep it the same as Doctrine\Common\Reflection\Psr0FindFile but constructors are not part of the interface. Less code not doing anything is a good thing. And this is not disruptive at all. Removing dead code is allowable during beta. Committed 996325b and pushed to 8.0.x. Thanks!

  • alexpott committed 996325b on 8.0.x 
    Issue #2505193 by googletorp: MockFileFinder has empty contruct method

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.