Something broke between 1.21 and 1.22.

Go to the File Displays admin: /admin/structure/file-types/manage/video/file-display

Notice the Vimeo Preview Image box is not enabled. Try to enable it and save. You'll get the error: "An illegal choice has been detected. Please contact the site administrator."

CommentFileSizeAuthor
#9 panopoly_widgets-vimeo-config-2504829-9.patch653 bytesdsnopek
#7 panopoly_widgets-update_vimeo-2504829-7.patch650 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Priority: Normal » Critical
Issue tags: +sprint

Marking as "Critical" because this is a regression!

mpotter’s picture

mpotter CreditAttribution: mpotter commented

Updating to latest media_vimeo module doesn't fix this, so likely something in the latest Media?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

This could have been caused by the upgrade to Media 2.0-alpha4: #2445119: Update Media to 2.0-alpha4

To test we can try reverting to the version of Media from Panopoly 1.21. Here's the .make excerpt:

projects[media][version] = 2.x-dev
projects[media][subdir] = contrib
projects[media][download][type] = git
projects[media][download][revision] = 6382429
projects[media][download][branch] = 7.x-2.x
projects[media][patch][2192981] = http://drupal.org/files/issues/media-restore-edit-button-2192981-13.patch
projects[media][patch][2126697] = http://drupal.org/files/issues/media-wysiwyg-alt-title-handling-2126697-27.patch
projects[media][patch][2308487] = http://drupal.org/files/issues/media-alt-title-double-encoded-2308487-1.patch
projects[media][patch][2084287] = http://www.drupal.org/files/issues/media-file-name-focus-2084287-2.patch
projects[media][patch][2421589] = http://www.drupal.org/files/issues/media-library-preview-overflow-2421589-2.patch
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

You can get the checkbox to save by doing the following:

  1. Select the "Vimeo Video" tab
  2. Check "Specify an http protocol"
  3. Choose either HTTP or HTTPS
  4. Click "Save configuration"

It seems like something might be wrong with that form, or the config we have saved in Features breaking that form...

mpotter’s picture

mpotter CreditAttribution: mpotter commented
Priority: Critical » Normal

This might be a red-herring. Vimeo previews are broken in Atrium in the Media Gallery paragraph (and show a Manual Crop image style for some reason).

If I embed a vimeo video with WYSIWYG and select Preview mode, it works.

If I enter a vimeo video into the normal Attachments field in an Atrium document, it works.

So it's just a Paragraphs issue, so I'll dig into this for Atrium. Moving this back to Normal since this checkbox and illegal selection seems to have been around for a long time and isn't as big an issue as I thought.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented
Title: Vimeo preview images not working » Update Vimeo configuration export
Assigned: Unassigned » mglaman

Issue here is a stale Vimeo file display export, going to work on patch now.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented
Assigned: mglaman » Unassigned
Status: Active » Needs review
FileSize
panopoly_widgets-update_vimeo-2504829-7.patch650 bytes

I think the issue is this logic in hook_file_default_displays_alter(). It was setting the protocol to // which is invalid.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented

Travis run off of my fork https://travis-ci.org/mglaman/panopoly/builds/70542646

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
panopoly_widgets-vimeo-config-2504829-9.patch653 bytes

Actually, I think it would be better to not specify a protocol at all. Here's an attempt at a patch to do that!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/71441582

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn at NBCUniversal commented
Status: Needs review » Reviewed & tested by the community

Looks good! Tested it and the config form saves without errors and the Vimeo preview image now shows in the WYSIWYG area.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Reviewed & tested by the community » Fixed

@Elijah: Thanks for testing! Committed. :-)

  • dsnopek committed 82a4fcc on 7.x-1.x 
    Update Panopoly Widgets for Issue #2504829 by dsnopek, mglaman, mpotter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.