Fatal error when clicking 'in progress' without a translator

Fixed a couple syntax issues as well as the fix for the issue. Hard to recreate.

This is a more general followup to investigate one of the roots of the problem #2538360: Verify stability with existing jobs when deleting a translator

Added tests on this.

Ups and ill have a look at that.

Please pass a patch only containing relevant changes.
We don't apply code style fixes mixed with functional changes.
Also it makes reviewing very hard.

We can have a separate task if you want to propose code cleanup.. But make sure to find a proper moment when it does not clash with too many issues with patches. We don't commit cosmetic fixes if it breaks active work.

okay, im uploading the patch with the functional changes only.

+++ b/src/Form/JobItemForm.php
@@ -423,13 +423,16 @@ class JobItemForm extends TmgmtFormBase {
-

Irrelevant change.

+++ b/src/Form/JobItemForm.php
@@ -423,13 +423,16 @@ class JobItemForm extends TmgmtFormBase {
         // Give the translator ui controller a chance to affect the data item element.

Forgot this... The comment is longer than 80 characters.

Okay, uploaded interdiff as well.

12.- thats a separate change, nothing to do with this issue nor added by me. As stated before we need to clean the whole class, also the comment above in the class is over 80 chars.

1. +++ b/sources/content/src/Tests/ContentEntitySourceUiTest.php
   @@ -107,6 +107,20 @@ class ContentEntitySourceUiTest extends EntityTestBase {
   +    $this->clickLink('Translate');
   

Maybe not for assetText(), but I'm pretty sure that we should have t() for links/buttons.

2. +++ b/src/Form/JobItemForm.php
   @@ -425,11 +425,15 @@ class JobItemForm extends TmgmtFormBase {
   +            ->createUiInstance($job_item->getTranslator()->getPluginId())
   

   The method name is createUIInstance().

Both fixed, none of them are related to my issue they were there before so i would suggest to clean up the class, since there are lots of other things like this.

This looks good.

When working on a bugfix (and this is, so it is not a task :)), always provide a test-only patch as the first file, which is supposed to fail. That makes it easy for reviewers to see that the test is in fact covering the broken scenario and fails without the fix.

Done.

Thanks, committed.