Including a non-gpl 3rd party library breaks the Terms of Service

Hello, We have a problem with the best practise for this case. First I'm going to explain how we use the library:

We only use a class of PHPLOC (Analyser in Analyser.php), no the rest of the project. This class has been modified to add new attributes, functions and global variables not has been modified. In summary we use only a file of the total library.

We have received many possible solutions, like to make a fork to PHPLOC, I think that is very tedious for a little part of code that we use.

Is possible to add this class of PHPLOC code as part of smartest module with BSD lisence?
What do you think about the best solution in this case?

thanks @David_Hernández

You can see the class there: https://github.com/sebastianbergmann/phploc/blob/master/src/Analyser.php

Sorry, I said that we modified PHPLOC library, but now I search the PHPLOC repository and has changes. these changes make that we not have to modified the library. We can use it as it is now. Therefore we use Libraries API to integrate PHPLOC in our module, as you propose.

thank you very much.

The code was modified like appears in "patch Issue #2504591.diff" for this issue.

We have deleted the code of the class Analyser.php of phploc from our module, following your instructions. Now expected to be extracted into 'sites/all/libraries/phploc'.

@gabrielhruiz
The patch is not following the Drupal name signature. Should be a file with the following structure
_#issue-#comment.patch.

In other hand, every time a patch is posted the issue state should be update to Needs Review. In [1] you can check all the drupal issue status and what means.

[1] https://www.drupal.org/issue-queue/status

I change the issue status to Needs Review.

Sorry, this is the .patch file for this issue.

@babrielhruiz, thanks for the update but I think I didn't explain as well as I supposed :p.
The patch should be something like this: add_hooklibrary_2504591-7.patch where :

- add_hooklibrary is a short issue description
- 2504591: The issue number aka #issue
- 7: The comment number where I'm posting the patch aka #comment

I recommend you use Dreditor [1]

[1] https://dreditor.org/

Thanks you for the explanation. I add a correct patch.

What I see in the patch.

 */
		+function smartest_requirements($phase) {
		+  $requirements = array();
		+  // Ensure translations do not break at install time
		+  $t = get_t();

In line comments should ends with '.'

+function smartest_autoload_info() {  <--- here
		+  $path = libraries_get_path('phploc');
		+  return array(

function smartest_phploc_libraries_info() { <--- here
		+
		+  // Expected to be extracted into 'sites/all/libraries/simple'.
		+  $libraries['phploc'] = array(
		+    'name' => 'phploc',

There are functions without comments.

Add hooks comments and ends comments fixed.

@gabrielhruiz great patch but I think the patch is not correct, I mean the patch only have the comments and should have all the code from patch #8. Also, an interdiff file could be great to check what is new.
Create an interdiff is easy, you only have to create a branch with the patch #8 and other with the patch #11 and execute git diff between the branches.

Also I saw you change the patch name from add_hooklibrary to implement_comment_lines. That's not a problem but I'm not sure if you did it because you believe that each patch have to change it's name depending what you do on it. The patch name, AFAIK, should have a short description of the issue and not the last change it is done.

If you has any doubt you can try to ask in #drupal-es or #drupal-contribute IRC channels

Upload patch wich contains the changes only of this issue.

this .patch contains changes in other hooks that isn't appear in #14 comment, because were necessary to resolve the problem of .info.

The correct patch with all changes.

Last changes.

The code is good for me too.