All line items displayed when array empty in commerce_line_item_field_widget_form

Tagging. Patch will need review for code formatting.

+++ b/modules/line_item/commerce_line_item.module
@@ -999,7 +999,12 @@ function commerce_line_item_field_widget_form(&$form, &$form_state, $field, $ins
+      $line_items = commerce_line_item_load_multiple($line_item_ids);

Shouldn't commerce_line_item_load_multiple() return an empty array from entity_load() anyways?

It's actually a lovely "feature" that it will return literally every entity of the given type. Not sure what drove that decision. : P

Marking this as RTBC, then. Looks good, will properly handle empty line items.

Only change is we could make it

$line_items = (!empty($line_item_ids)) ? commerce_line_item_load_multiple($line_item_ids) : array();

But that's super nitpick, and broken out it's easier to read logic going on here and assume why we're doing this check.

Nit picking is good. : D

I think we generally prefer the if / else block over the ternary operator. We do need to fix the code style though to remove the extra line of whitespace and put the curly brace before the else on a line by itself.