ThemeNegotiatorPass was removed, but the ThemeNegotiator docblock still has a @see pointing to it.
Let's remove it.

Nitpicky patch of the day.

CommentFileSizeAuthor
#3 2504013-2-remove-theme-negotiator-see.patch553 bytesbojanz
#1 2504013-1-remove-non-existent-see.patch547 bytesbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Active » Needs review
FileSize
2504013-1-remove-non-existent-see.patch547 bytes
cilefen’s picture

cilefen CreditAttribution: cilefen commented 
+++ b/core/lib/Drupal/Core/Theme/ThemeNegotiator.php
@@ -15,7 +15,6 @@
  * @see \Drupal\Core\Theme\ThemeNegotiatorInterface

Is it normal to provide a @see for an interface a class implements?

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Title: Remove @see for a non-existent class » Remove @see statements from the ThemeNegotiator docblock
FileSize
2504013-2-remove-theme-negotiator-see.patch553 bytes

@cilefen
No, that makes 0 sense. Let's kill it.

Kazanir’s picture

Kazanir CreditAttribution: Kazanir commented
Status: Needs review » Reviewed & tested by the community

lgtm

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed fc8b68e on 8.0.x 
    Issue #2504013 by bojanz: Remove @see statements from the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.