Link field default options values should be array

Manually tested too

Screenshot https://www.dropbox.com/s/2y5y35qeihx32kv/Screenshot%202015-06-10%2007.4...

+++ b/core/modules/system/src/Tests/System/TrustedHostsTest.php
@@ -97,7 +97,7 @@ public function testShortcut() {
-      'link' => 'internal:/admin/reports/status',
+      'link' => ['uri' => 'internal:/admin/reports/status'],

Why is this change necessary - isn't uri the main property?

back again

+++ b/core/modules/link/src/Plugin/Field/FieldType/LinkItem.php
@@ -184,6 +184,9 @@ public function setValue($values, $notify = TRUE) {
+    if (!is_string($values) && !isset($values['options'])) {
+      $values['options'] = [];
+    }

I'm not sure that the !is_string($values) is actually necessary. If it is a string $values['options'] will be set.

@alexpott: So you are proposing to rely on PHP's behavior that $foo = 'abc'; isset($foo['bar']); returns TRUE? I have to strongly disagree, I think it makes the code wildly less readable. When you read isset($foo['bar']) no one would expect $foo to be a string. I'm fine with changing the !isset() to is_array() if people prefer that, but...

Marking "needs review" to get some more opinions on this.

Agree with @tstoeckler

1. I like the new approach much cleaner.

2. +++ b/core/modules/link/src/Plugin/Field/FieldType/LinkItem.php
   @@ -177,6 +177,15 @@ public function getUrl() {
   +      $values = ['uri' => $values];
   

   I think we should use $this->mainPropertyName() instead of hardcoding 'uri' here.

3. +++ b/core/modules/link/src/Plugin/Field/FieldType/LinkItem.php
   @@ -177,6 +177,15 @@ public function getUrl() {
   +      'title' => NULL,
   

   Why add title? It's optional?

4.     if (isset($values['options']) && is_string($values['options'])) {
         $values['options'] = unserialize($values['options']);
       }
   

   No longer necessary to check if $values['options'] is set - it will always be.

looks good

Committed e5d87b1 and pushed to 8.0.x. Thanks!

diff --git a/core/modules/link/src/Tests/LinkItemTest.php b/core/modules/link/src/Tests/LinkItemTest.php
index a476853..382a464 100644
--- a/core/modules/link/src/Tests/LinkItemTest.php
+++ b/core/modules/link/src/Tests/LinkItemTest.php
@@ -130,7 +130,6 @@ public function testLinkItem() {
     $entity->field_test[0] = NULL;
     $this->assertNull($entity->field_test[0]->getValue());
 
-
     // Test the generateSampleValue() method.
     $entity = entity_create('entity_test');
     $entity->field_test->generateSampleItems();

Removed unnecessary empty line on commit.