Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
CSS
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Jun 2015 at 00:16 UTC
Updated:
14 Sep 2015 at 07:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Alka Kumari commentedComment #2
Alka Kumari commentedComment #3
pguillard commentedthey seem not to be used anywhere indeed
Comment #4
prajaankit commentedComment #5
lewisnymanI looked for these classes and couldn't find them in core. I think there might be a few more classes that aren't being used in this file:
This can go as well:
Comment #6
pguillard commentedI applied #5
Comment #7
pguillard commentedComment #8
JMC commentedReviewing this at DrupalCampNorth sprint today with @LewisNyman.
Everything seems correct except for the references to the odd and even classes don't seem to have been removed in the patch. Lewis said this references the work here #1649780: Remove first/last/odd/even classes in favor of CSS3 pseudo selectors.
I'll try to add this to the patch...
Comment #9
lewisnymanComment #10
JMC commentedComment #11
JMC commentedComment #12
lewisnymanGreat! Thanks for making these changes. Less CSS!
Comment #13
lauriiiComment #14
alexpottCan we get screenshots before and after of config being diffed through the UI.
Also I don't think we're using...
Comment #15
lewisnymanComment #16
pjbaert@alexpott
After a search, I noticed that there is still a reference to
.diffchangein the HWLDFWordAccumulator.php fileComment #17
pguillard commentedHere are the screenshots :
Before :

After :

Comment #18
pguillard commentedComment #19
lewisnymanGreat, thanks for adding the screenshots. Setting back to RTBC based on the comment in #16.
Comment #20
alexpottCommitted 346567c and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.